Skip to content
This repository was archived by the owner on Feb 28, 2025. It is now read-only.

Conversation

@panleone
Copy link

What was done?

Introduce the struct PayoutShare and replace the field payout_address of DMNState and DMNStateDiff with payout_shares, which is Vec<PayoutShare>.

Then deserialize in such a way to convert the payout_address returned by the core wallet rpc in the one-element vector [PayoutShare{payout_address, 10000}].

(NB: clearly once DIP0026 is released on core wallet the deserialization part has to be changed)

Why was it done?

The aim of this PR is continuing the implementation (or at least give some ideas) of DIP0026 on platform, see here why the feature is needed completed on platform before being released by core wallet.

In particular with this PR merged the only steps left should be:

  1. Create an identity for each element of payout_shares in the function update_masternode_identities_v0
  2. For each identity created, create also a document of the contract reward-shares-contract

And that should be enough since the platform already pays reward-shares-contract see here

How Has This Been Tested?

The unit test deserialize_mn_listdiff is still working as expected

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant