Skip to content

feat: add DIP-17 Platform Address Funding key support#403

Draft
pauldelucia wants to merge 2 commits intov0.42-devfrom
feat/dip17-platform-address-funding
Draft

feat: add DIP-17 Platform Address Funding key support#403
pauldelucia wants to merge 2 commits intov0.42-devfrom
feat/dip17-platform-address-funding

Conversation

@pauldelucia
Copy link
Member

Add PlatformAddressFunding account type for DIP-17 funding keys with derivation path m/9'/coin_type'/17'/0'/2'/index. This enables wallets to generate funding addresses for Platform operations.

Changes:

  • Add DerivationPathReference::PlatformAddressFunding (value 17)
  • Add platform_address_funding_path() helper in bip32.rs
  • Add AccountType::PlatformAddressFunding variant
  • Add ManagedAccountType::PlatformAddressFunding with address pool
  • Update transaction router to check PlatformAddressFunding for AssetLock
  • Add FFI bindings for platform address funding functionality

Add PlatformAddressFunding account type for DIP-17 funding keys with
derivation path m/9'/coin_type'/17'/0'/2'/index. This enables wallets
to generate funding addresses for Platform operations.

Changes:
- Add DerivationPathReference::PlatformAddressFunding (value 17)
- Add platform_address_funding_path() helper in bip32.rs
- Add AccountType::PlatformAddressFunding variant
- Add ManagedAccountType::PlatformAddressFunding with address pool
- Update transaction router to check PlatformAddressFunding for AssetLock
- Add FFI bindings for platform address funding functionality

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

Warning

Rate limit exceeded

@pauldelucia has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 3 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/dip17-platform-address-funding

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pauldelucia pauldelucia marked this pull request as draft February 2, 2026 08:31
@github-actions github-actions bot added the merge-conflict The PR conflicts with the target branch. label Feb 2, 2026
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR conflicts with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant