Skip to content

Conversation

@ZocoLini
Copy link
Collaborator

@ZocoLini ZocoLini commented Feb 4, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved progress monitoring accuracy by ensuring the latest progress state is captured and delivered in callback updates.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

The code now uses borrow_and_update() instead of borrows() to obtain current progress values in the progress monitoring path, affecting both initial dispatch and subsequent updates. This ensures the latest progress state is captured before cloning and sending to callbacks.

Changes

Cohort / File(s) Summary
Progress Monitoring Path
dash-spv-ffi/src/client.rs
Replaced borrows() calls with borrow_and_update() to ensure latest progress state is obtained before dispatching to callback in progress monitoring flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through progress states so fine,
Updating borrows to keep timing in line,
Two little changes, precise and divine,
Now callbacks receive the freshest design! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title references 'cooldown' and 'wait for updates' but the raw summary only describes a change from borrows to borrow_and_update() to ensure latest progress state before cloning, with no mention of cooldown logic or event dispatch prevention. Align the title with the actual changes described: the modification to use borrow_and_update() for obtaining current progress values, not cooldown-based event dispatch.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/ffi-events-dispatch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xdustinface xdustinface merged commit 2d3a531 into v0.42-dev Feb 4, 2026
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants