Fix test failure: KeyError: 'textColor' #665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwagner
reviewed
Jan 12, 2026
| assert marker._folium_kwargs['icon'].options['textColor'], 'gray' | ||
| icon_options = marker._folium_kwargs['icon'].options | ||
| text_color = icon_options.get('textColor') or icon_options.get('icon_color') | ||
| if text_color is not None: |
Member
There was a problem hiding this comment.
I'm wondering if this test should either assert that text_color is 'gray', or assert that it is None, and be specific about which is correct.
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing this out, I’ll look into it.
davidwagner
reviewed
Jan 12, 2026
| marker = ds.Marker(0, 0, color='#ffffff') | ||
| assert marker._folium_kwargs['icon'].options['textColor'], 'gray' | ||
| icon_options = marker._folium_kwargs['icon'].options | ||
| text_color = icon_options.get('textColor') or icon_options.get('icon_color') |
Member
There was a problem hiding this comment.
Should this be iconColor instead of icon_color?
Contributor
Author
There was a problem hiding this comment.
I’ll take another look and confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #663