Ensure plots with Year on X-Axis have only integers #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwagner
reviewed
Jan 13, 2026
chapters/07/Visualization.ipynb
Outdated
| ] | ||
| }, | ||
| "metadata": {}, | ||
| "output_type": "display_data" | ||
| } | ||
| ], | ||
| "source": [ | ||
| "century_21.plot('Year', 'Number of Movies')" | ||
| "century_21.plot('Year2', 'Number of Movies')\n", |
Member
There was a problem hiding this comment.
I'm guessing Year2 is a typo and it should be Year?
Member
|
Thanks so much for finding a solution! I left one comment, otherwise it looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165
I understand if we don't want to merge this because it definitely goes beyond the simplicity in Data 8.
From what I looked into,
Yearis already definitely full of integers. When I cast it to integers, the plot doesn't change at all. What's happening is a result of howmatplotlibdecides to show the plot. We can edit thedatasciencepackage if you'd like (something like "if x or y values are integers, then insert my fix here). Or we can just leave it as is.