Conversation
WalkthroughA GitHub Actions workflow file was updated to add a Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/azure-static-web-apps-wonderful-mushroom-02abe3903.yml (1)
19-19:⚠️ Potential issue | 🔴 CriticalCritical: Job will be skipped when manually triggered.
The
build_and_deploy_jobconditional doesn't includeworkflow_dispatchevents. When the workflow is manually triggered,github.event_namewill be'workflow_dispatch', which doesn't match the current condition. The job will be skipped, defeating the entire purpose of this PR.🐛 Proposed fix to include workflow_dispatch events
- if: github.event_name == 'push' || (github.event_name == 'pull_request' && github.event.action != 'closed') + if: github.event_name == 'push' || github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && github.event.action != 'closed')
Description
be able to run deploy without needing to push to master
Documentation
Summary by CodeRabbit