Skip to content

优化登陆页面的开放重定向问题 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BorisPolonsky wants to merge 2 commits into
base: main
Choose a base branch
from
Open

优化登陆页面的开放重定向问题 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
330b0e1
Fix open redirect vulnerability during login: `login_url` should matc…
BorisPolonsky Sep 8, 2025
343d863
Patch the redirection when login_url wasn't specified
BorisPolonsky Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion install/docker/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,11 @@ def login(self):
if user:
login_user(user, remember=True)
if comed_url:
return redirect(comed_url)
# 仅开放同域名跳转，避免开放式URL重定向漏洞
from werkzeug.urls import url_parse
parsed_url = url_parse(comed_url)
if (not parsed_url.netloc and parsed_url.path) or parsed_url.netloc == request.host:
return redirect(comed_url)
return redirect(self.appbuilder.get_url_for_index)
# 如果已经登录了，那么直接进去首页
if g.user is not None and g.user.is_authenticated:
Expand Down
6 changes: 5 additions & 1 deletion install/kubernetes/cube/overlays/config/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,11 @@ def login(self):
if user:
login_user(user, remember=True)
if comed_url:
return redirect(comed_url)
# 仅开放同域名跳转，避免开放式URL重定向漏洞
from werkzeug.urls import url_parse
parsed_url = url_parse(comed_url)
if (not parsed_url.netloc and parsed_url.path) or parsed_url.netloc == request.host:
return redirect(comed_url)
return redirect(self.appbuilder.get_url_for_index)
# 如果已经登录了，那么直接进去首页
if g.user is not None and g.user.is_authenticated:
Expand Down
6 changes: 5 additions & 1 deletion myapp/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,11 @@ def login(self):
if user:
login_user(user, remember=True)
if comed_url:
return redirect(comed_url)
# 仅开放同域名跳转，避免开放式URL重定向漏洞
from werkzeug.urls import url_parse
parsed_url = url_parse(comed_url)
if (not parsed_url.netloc and parsed_url.path) or parsed_url.netloc == request.host:
return redirect(comed_url)
return redirect(self.appbuilder.get_url_for_index)

if g.user is not None and g.user.is_authenticated:
Expand Down