Redact Private Key from CreateWallet API Response#521
Closed
Sankara-Jefferson wants to merge 42 commits intomainfrom
Closed
Redact Private Key from CreateWallet API Response#521Sankara-Jefferson wants to merge 42 commits intomainfrom
Sankara-Jefferson wants to merge 42 commits intomainfrom
Conversation
ianconsolata
approved these changes
Jul 29, 2025
Collaborator
ianconsolata
left a comment
ianconsolata
left a comment
There was a problem hiding this comment.
LGTM, though it seems like there are some merge conflicts to resolve
Co-authored-by: web3-bot <web3-bot@users.noreply.github.com>
There seem to have been some manual releases which leaves version file inconsistent with what the latest release is.
This is the version for MVP milestone
New version includes retrieval optimization.
- update go-libp2p to v0.39.1 - enable HTTP(S)_PROXY and TCP_PROXY
- Add init function to create full current schema on brand new clean databases and run missing migrations on any databases using old auto-migrate strategy with existing data. - Add CLI commands to migrate up, down, or to a specified version by ID - Add utility functions to get list of migration IDs ran on current database, check if migration has run by ID, etc.
Fix struct tag ordering in handler/storage/types_gen.go to match the current code generator output. This resolves CI failures where go generate was detecting differences between committed and generated files.
Merging this now — all tests have passed.
Add Wallet Create Handler + Migrate to Numeric Wallet ID. Merging as all local test passed. The go version error will be addressed on a separate issue.
Collaborator
|
this, in addition to not having a sane history, is only relevant with wallet creation functionality closing this and will be mindful of this issue when re-implementing wallets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR redacts the
PrivateKeyfield from the response of the/wallet/createAPI endpoint to prevent accidental key exposure.What Was Done
CreateHandler: removedPrivateKeyfrom response payload by explicitly clearing the field before return.CreateWallet_privateKeyShouldBeRedactedto assert thatPrivateKeyis empty in the response.go test ./api -v.Rationale
Previously, the
PrivateKeywas included in plaintext in API responses. While this endpoint is useful for testing, returning secrets by default is a major security risk. This patch minimizes attack surface and sets groundwork for further key safety improvements.Follow-ups (to be tracked)
wallet export)Status
Ready for merge after CI passes.