fix add-piece to lookup existing pieces by CID#607
Merged
Conversation
Collaborator
Author
|
Brian is currently blocked on a big backfill without this functionality so I am tempted to sneak it in also... please tell me if I should stay my hand 😉 |
Collaborator
Author
|
given that this is an advanced/non-core feature and now labeled as such I am going to merge, it's still pretty tricky but less brittle and more functional than it was |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes a bunch of problems with the add-piece command, which remains somewhat problematic but should now work for the "add pieces from one prep to another prep" use case, which is useful when you want to send a "meta-prep" of a bunch of failed pieces from previous preps instead of re-running all of the schedules
I had previously done this by... literally direct DB manipulation, not recommended