Skip to content

Improve blog updater [WIP]#563

Open
hlib-lozhkovyi wants to merge 48 commits intodevfrom
improve_blog_updated
Open

Improve blog updater [WIP]#563
hlib-lozhkovyi wants to merge 48 commits intodevfrom
improve_blog_updated

Conversation

@hlib-lozhkovyi
Copy link
Contributor

@hlib-lozhkovyi hlib-lozhkovyi commented Mar 8, 2018

Fixes #546, #551, #550, #638, #619, #631

@hlib-lozhkovyi
Copy link
Contributor Author

Blog Updater now use the same component as Blog List to show "real" preview realtime

screen shot 2018-03-08 at 4 12 31 pm

@hlib-lozhkovyi
Copy link
Contributor Author

Typical Blog Updater form

screencapture-localhost-3000-admin-cms-recent-1520518447085

@hlib-lozhkovyi
Copy link
Contributor Author

hlib-lozhkovyi commented Mar 8, 2018

@kylepolich Right now update form is ultra long. Maybe better to move it into a single page? In that case we could add pencil (direct link to edit/update) at Blog page only for admin.

Something like this (mock)
screen shot 2018-03-08 at 4 17 57 pm

@hlib-lozhkovyi hlib-lozhkovyi changed the title Improve blog updated [WIP] Improve blog updater [WIP] Mar 8, 2018
@kylepolich
Copy link
Contributor

@gleblozhkovoy I love it. Good instincts.

Gleb Lozhkovoy added 7 commits March 9, 2018 09:29
# Conflicts:
#	backend/api/v1/files.js
#	backend/api/v1/index.js
#	shared/Blog/Components/BlogListItem.js
#	shared/Forms/Components/DragAndDropFileUploadField.js
#	shared/Forms/Components/Field/Field.js
#	shared/Forms/Components/FilePreview.js
#	shared/Forms/Components/ImageUploadField.js
# Conflicts:
#	shared/Forms/Components/Field/Select.js
@kylepolich
Copy link
Contributor

Please add the option to upload for content type "Person"

screen shot 2018-03-31 at 11 48 45 pm

@kylepolich
Copy link
Contributor

kylepolich commented Apr 1, 2018

@gliblozhkovyi

  • When I try to re-upload an image (replace an image) the new image is not saved.

@kylepolich
Copy link
Contributor

@gliblozhkovyi Could you estimate when the issues mentioned above will be addressed?

@hlib-lozhkovyi
Copy link
Contributor Author

Seeing this error. Please address:
UNSUPPORTED TYPE: mp3
2RelatedContent.js:79

That legacy code which I wasn't confident enough to remove. In fact, that's happened because we have a live preview of blog post items and mp3 is not supported to show (we are using it in blog post)

@hlib-lozhkovyi
Copy link
Contributor Author

When I try to re-upload an image (replace an image) the new image is not saved.

As I mentioned before, we have not an endpoint to update related items (except create/delete) yet.
We could follow autoreplace way as we have on careers page, but that solution is OK for single place and will require a lot of stuff from my side to implement for related items.

@hlib-lozhkovyi hlib-lozhkovyi changed the title Improve blog updater Improve blog updater [WIP] Apr 6, 2018
@hlib-lozhkovyi
Copy link
Contributor Author

I have added requested form with lambda request #631. (Accessible at http://localhost:3000/admin/cms/contributors/add)

Post request is working, but lambda returns a list. Is that expected on current point or I'm doing something wrong?

@kylepolich
Copy link
Contributor

@gliblozhkovyi It returns a list which should include the update you sent. Would you prefer I return something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants