upgrade pgwire #111
Open
upgrade pgwire #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Rust toolchain from version 1.82.0 to 1.85.0 and updates some dependencies to maintain compatibility with the newer Rust version.
- Rust toolchain upgraded from 1.82.0 to 1.85.0
- Added arrow-pg dependency to trex crate
- Updated lazy-regex dependency from 3.1.0 to 3.3.0
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rust-toolchain.toml | Updates Rust toolchain version to 1.85.0 |
| Dockerfile.trex | Updates Docker base image to use Rust 1.85.0 |
| ext/trex/Cargo.toml | Adds arrow-pg dependency for trex extension |
| Cargo.toml | Updates lazy-regex dependency to version 3.3.0 |
| tracing-subscriber = { workspace = true, default-features = true, features = [ | ||
| "env-filter", | ||
| ] } | ||
| arrow-pg = { version = "0.*", default-features = false } |
There was a problem hiding this comment.
Using a wildcard version specification '0.*' is not recommended as it can lead to unexpected breaking changes. Consider specifying a more precise version range like '0.1' or '~0.1.0' to ensure better dependency stability.
Suggested change
| arrow-pg = { version = "0.*", default-features = false } | |
| arrow-pg = { version = "0.1", default-features = false } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.