Skip to content

Disable Checksum Validation for Github URLs #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahirreddy wants to merge 1 commit into
base: databricks-bazel-5.3.0
Choose a base branch
from
Open

Disable Checksum Validation for Github URLs #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...va/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkRepositoryContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,6 +1032,11 @@ private Checksum calculateChecksum(Optional<Checksum> originalChecksum, Path pat

private Optional<Checksum> validateChecksum(String sha256, String integrity, List<URL> urls)
throws RepositoryFunctionException, EvalException {
if (urls.size() == 1 && urls.get(0).getHost().contains("github.com")) {
// If the URL from Github and we don't have any other URLs from which to pull, we don't need
// to validate the checksum
return Optional.absent();
}
if (!sha256.isEmpty()) {
if (!integrity.isEmpty()) {
throw Starlark.errorf("Expected either 'sha256' or 'integrity', but not both");
Expand Down