Flip IgnoreTransactions default from 0 to 1 for multi-statement transaction preview #1176
+42
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the default behavior of transaction support in the JDBC driver to address issues with BI tools during the private preview phase of multi-statement transactions. The default value of IgnoreTransactions is flipped from 0 to 1, effectively disabling transaction support by default.
- Changed default value of
IgnoreTransactionsparameter from0to1in the enum definition - Updated
supportsTransactions()method to return the inverse ofgetIgnoreTransactions()instead of hardcodedtrue - Removed hardcoded default value "0" from
getIgnoreTransactions()implementation, now uses enum default - Updated test naming and added test case for explicitly enabled transactions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/com/databricks/jdbc/common/DatabricksJdbcUrlParams.java | Changed IGNORE_TRANSACTIONS default value from "0" to "1" |
| src/main/java/com/databricks/jdbc/api/impl/DatabricksDatabaseMetaData.java | Updated supportsTransactions() to respect IgnoreTransactions flag |
| src/main/java/com/databricks/jdbc/api/impl/DatabricksConnectionContext.java | Removed hardcoded default "0", now uses enum default value |
| src/test/java/com/databricks/jdbc/api/impl/DatabricksDatabaseMetaDataTest.java | Renamed test and added new test for enabled transactions scenario |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vikrantpuppala
force-pushed
the
flip-ignore-transactions-default
branch
2 times, most recently
from
085233a to
3b04de0
Compare
…action preview Change the default value of IgnoreTransactions from "0" (disabled) to "1" (enabled) to prevent unexpected failures for customers not enrolled in the multi-statement transaction private preview. Preview participants can opt-in by explicitly setting IgnoreTransactions=0 in their connection string. Also update supportsTransactions() to respect the IgnoreTransactions flag, returning false when transactions are ignored (default) and true when explicitly enabled. Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
vikrantpuppala
force-pushed
the
flip-ignore-transactions-default
branch
from
3b04de0 to
bce4cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IgnoreTransactionsparameter from0to1, making transactions disabled by defaultsupportsTransactions()to respect theIgnoreTransactionsflag, returningfalsewhen transactions are ignored (default) andtruewhen explicitly enabledIgnoreTransactions=0Background
The multi-statement transaction feature is currently in private preview for limited workspaces. When BI tools (Tableau, Power BI, DBeaver) detect transaction support via
supportsTransactions(), they automatically use transaction methods, causing failures for customers not enrolled in the preview.This change prevents unexpected failures for non-preview customers while allowing preview participants to opt-in by explicitly setting
IgnoreTransactions=0in their connection string.Migration Path
IgnoreTransactions=0in connection string to enable transaction support0Test plan
supportsTransactions() = falseIgnoreTransactions=0returnssupportsTransactions() = truesetAutoCommit,commit,rollback) are no-ops by default🤖 Generated with Claude Code