Skip to content

Support Client ID/Secret Authentication #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jasondamour wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −7
Draft

Support Client ID/Secret Authentication #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions modules/aws-workspace-with-firewall/providers.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ provider "aws" {

// initialize provider in "MWS" mode to provision new workspace
provider "databricks" {
alias = "mws"
host = "https://accounts.cloud.databricks.com"
username = var.databricks_account_username
password = var.databricks_account_password
}
alias = "mws"
host = "https://accounts.cloud.databricks.com"
username = var.databricks_account_username
password = var.databricks_account_password
Comment on lines +9 to +10
Copy link
Collaborator

@alexott alexott May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you either need to use username/password or client_id/client_secret, not both

client_id = var.databricks_account_client_id
client_secret = var.databricks_account_client_secret
}
6 changes: 4 additions & 2 deletions modules/aws-workspace-with-firewall/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
variable "databricks_account_id" {}
variable "databricks_account_username" {}
variable "databricks_account_password" {}
Comment on lines 2 to 3
Copy link
Collaborator

@alexott alexott May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

variable "databricks_account_id" {}
variable "databricks_account_client_id" {}
variable "databricks_account_client_secret" {}

variable "tags" {
default = {}
Expand Down Expand Up @@ -42,4 +44,4 @@ variable "db_control_plane" {

variable "prefix" {
default = "demo"
}
}