Generate preamble code #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikehara
force-pushed
the
feature/generate-preamble
branch
from
d1b33ea to
2c992cd
Compare
bluele
reviewed
Oct 10, 2019
hmcdk/codegen/src/lib.rs
Outdated
| }; | ||
| Ok(a) | ||
| } | ||
| None => Err("invalid arg type".to_string()) |
Member
There was a problem hiding this comment.
please add type and argument info to error message
| None => Err("invalid arg type".to_string()) | ||
| } | ||
| } | ||
| _ => Err("invalid arg type".to_string()) |
Member
There was a problem hiding this comment.
please add type and argument info to error message
hmcdk/abi/src/types.rs
Outdated
| Integer(AbiInteger), | ||
| Bytes, | ||
| Address, | ||
| Hash, |
hmcdk/abi/src/types.rs
Outdated
| @@ -0,0 +1,54 @@ | |||
|
|
|||
Member
Contributor
Author
The code generation in #64 is done based on the parsed ast of a source file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to pass parameters to a contract as function arguments in rust code.
This might be helpful for client code generation because we can easily determine
what parameters each contract entry point has by just parsing a source code.
I'm not sure what kind of types should be accepted as parameters.
Do you think everything (convertible to bytes) should be ok or there should be
a certain group of types which is acceptable for entry points.