Skip to content

Comments

Add support for geoLocation metadata#206

Merged
svogt0511 merged 11 commits intomasterfrom
pb88-geolocation
Oct 15, 2025
Merged

Add support for geoLocation metadata#206
svogt0511 merged 11 commits intomasterfrom
pb88-geolocation

Conversation

@svogt0511
Copy link
Contributor

@svogt0511 svogt0511 commented Aug 14, 2025

Purpose

Add inPolygonPoint to geoLocationPolygon xml. Remove mapping of array of geoLocationPolygons to JSON geoLocations as it is not supported.

related to: datacite/product-backlog#88

Approach

Modify code that handles geoLocations in DataCite DOIs to include all fields of geoLocationPolygons:

  • lib/bolognese/datacite_utils.rb
  • lib/bolognese/readers/datacite_reader.rb

Modify translations to other metadata formats. The only modification necessary was for schema.org where it doesn't support inPolygonPoint for geoLocationPolygons:

  • lib/bolognese/utils.rb

Add some tests.

Update the version to 2.3.8

  • lib/bolognese/version.rb

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@svogt0511 svogt0511 self-assigned this Aug 14, 2025
@svogt0511 svogt0511 changed the title Add full support for geoLocation metadata Add support for geoLocation metadata Oct 6, 2025
@svogt0511 svogt0511 requested review from a team, ashwinisukale and codycooperross October 9, 2025 15:25
@svogt0511 svogt0511 merged commit edd36a6 into master Oct 15, 2025
5 checks passed
@svogt0511 svogt0511 deleted the pb88-geolocation branch October 15, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants