Skip to content

Comments

add update_schema_version before_save action#1192

Open
wendelfabianchinsamy wants to merge 4 commits intomasterfrom
set-schema-to-current-metadata-namespace
Open

add update_schema_version before_save action#1192
wendelfabianchinsamy wants to merge 4 commits intomasterfrom
set-schema-to-current-metadata-namespace

Conversation

@wendelfabianchinsamy
Copy link
Contributor

@wendelfabianchinsamy wendelfabianchinsamy commented Jun 4, 2024

Purpose

closes: datacite/datacite#1855

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy self-assigned this Jun 4, 2024
@jrhoads
Copy link
Contributor

jrhoads commented Jan 13, 2026

@wendelfabianchinsamy and @codycooperross
Is this still something we are interested in right now? I'm guessing not since it has been almost two years.
It should be fairly easy to recreate at a later date if desired.

If you folks agree let's close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The schemaVersion REST API attribute should only contain the current metadata schema version in a standard format

2 participants