Skip to content

Comments

Query builder (2 of 3): Refactor filters#1303

Open
jrhoads wants to merge 4 commits intomasterfrom
query-builder-refactor-filters
Open

Query builder (2 of 3): Refactor filters#1303
jrhoads wants to merge 4 commits intomasterfrom
query-builder-refactor-filters

Conversation

@jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Dec 12, 2024

Purpose

Make filters a bit more consistent. Consistently use the terms filter instead of term. Adjust parameters to pass in an array with a single element if it had previously been a term filter.

Open Questions and Pre-Merge TODOs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads jrhoads requested a review from a team December 12, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant