-
Notifications
You must be signed in to change notification settings - Fork 183
test(types): add unit tests for stream_configured.go and fix validation bugs #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
test(types): add unit tests for stream_configured.go and fix validation bugs #663
Conversation
|
@HarshitPal25 Please sign the CLA and rebase your PR to staging |
|
@HarshitPal25 Just a reminder can you please rebase your PR to staging and also sign the CLA. |
|
done changed the base to staging |
|
@HarshitPal25 Great! @vikaxsh will be reviewing your work. |
|
thank you |
Refactor tests for ConfiguredStream to use table-driven tests for better readability and maintainability. Updated test cases for GetFilter, GetDestinationDatabase, GetDestinationTable, and validation methods. Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
|
@vikaxsh i have changed the tests with table driven approach and update the grpc |
|
hi @HarshitPal25, is there any update ? |
|
@vikaxsh sorry I didn't get time my exams were going on but now I am free i had done mostly i would update it as soon as possible |
Added new test cases for stream configuration and validation, including checks for sync modes, cursor fields, and destination database precedence. Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
|
@vikaxsh please check i have changed and added what you like in the file |
|
Thank you so much for your contribution! Our team will get back to this shortly we’re currently working on a higher-priority task, so it may take about a week. In the meantime, feel free to reach out on Slack anytime. If you run into any issues, please post in the contributing-to-OLake channel and tag me I’ll be happy to help |
|
hey @HarshitPal25, please resolve the conflict with base branch and revert go.mod changes |
|
Hey @HarshitPal25 any update will have to de-assign then issue due to inactivity in some days |
Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
|
@vikaxsh i have revert the changes with the go.mod |
Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
|
@vikaxsh and @Akshay-datazip i have revert back the changes of the go.mod file. |
What changed:
How to verify:
Files touched:
types/stream_configured.go
types/stream_configured_test.go
Notes: This PR closes/fixes #649. Please review the validation logic in Validate() and the new test cases for coverage gaps or additional edge-cases to add.