Skip to content

Conversation

@HarshitPal25
Copy link

  • Summary: Fixes issues by correcting validation/behaviour in types/stream_configured.go and adding comprehensive unit tests to prevent regressions.

What changed:

  • Code: Updated types/stream_configured.go to fix validation and parsing edge-cases (cursor handling, filter parsing, and destination selection).
  • Tests: Added types/stream_configured_test.go with unit tests covering filter parsing, cursor behavior, destination selection, and Validate() scenarios.
  • Why: The changes ensure StreamConfigured behaves correctly when parsed/validated and catches regressions via unit
# from repo root
go test ./...        # run full test suite
go test ./types -run StreamConfigured -v   # run only the new/related tests

How to verify:
Files touched:
types/stream_configured.go
types/stream_configured_test.go
Notes: This PR closes/fixes #649. Please review the validation logic in Validate() and the new test cases for coverage gaps or additional edge-cases to add.

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2025

CLA assistant check
All committers have signed the CLA.

@nayanj98
Copy link
Collaborator

nayanj98 commented Dec 2, 2025

@HarshitPal25 Please sign the CLA and rebase your PR to staging

@HarshitPal25 HarshitPal25 changed the title test(types): add unit tests for stream_configured.go and fix validation bugs (#649) test(types): add unit tests for stream_configured.go and fix validation bugs Dec 2, 2025
@nayanj98
Copy link
Collaborator

nayanj98 commented Dec 9, 2025

@HarshitPal25 Just a reminder can you please rebase your PR to staging and also sign the CLA.

@HarshitPal25 HarshitPal25 changed the base branch from master to staging December 9, 2025 12:37
@HarshitPal25
Copy link
Author

done changed the base to staging

@nayanj98
Copy link
Collaborator

nayanj98 commented Dec 9, 2025

@HarshitPal25 Great! @vikaxsh will be reviewing your work.

@nayanj98 nayanj98 requested a review from vikaxsh December 9, 2025 12:52
@HarshitPal25
Copy link
Author

thank you

Refactor tests for ConfiguredStream to use table-driven tests for better readability and maintainability. Updated test cases for GetFilter, GetDestinationDatabase, GetDestinationTable, and validation methods.

Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
@HarshitPal25
Copy link
Author

@vikaxsh i have changed the tests with table driven approach and update the grpc

@vikaxsh
Copy link
Collaborator

vikaxsh commented Dec 30, 2025

hi @HarshitPal25, is there any update ?

@HarshitPal25
Copy link
Author

@vikaxsh sorry I didn't get time my exams were going on but now I am free i had done mostly i would update it as soon as possible

Added new test cases for stream configuration and validation, including checks for sync modes, cursor fields, and destination database precedence.

Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
@HarshitPal25
Copy link
Author

@vikaxsh please check i have changed and added what you like in the file

@datazip-inc datazip-inc deleted a comment from HarshitPal25 Jan 4, 2026
@datazip-inc datazip-inc deleted a comment from HarshitPal25 Jan 4, 2026
@datazip-inc datazip-inc deleted a comment from nayanj98 Jan 4, 2026
@Akshay-datazip
Copy link
Collaborator

Thank you so much for your contribution! Our team will get back to this shortly we’re currently working on a higher-priority task, so it may take about a week.

In the meantime, feel free to reach out on Slack anytime. If you run into any issues, please post in the contributing-to-OLake channel and tag me I’ll be happy to help

@Akshay-datazip Akshay-datazip added the SWoC26 Social Winter of Code label Jan 4, 2026
@vikaxsh
Copy link
Collaborator

vikaxsh commented Jan 5, 2026

hey @HarshitPal25, please resolve the conflict with base branch and revert go.mod changes

@Akshay-datazip
Copy link
Collaborator

Hey @HarshitPal25 any update will have to de-assign then issue due to inactivity in some days

@Akshay-datazip Akshay-datazip added the beginner easy issues for beginner contributors label Jan 9, 2026
Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
@HarshitPal25
Copy link
Author

@vikaxsh i have revert the changes with the go.mod

Signed-off-by: Harshit Pal <harshit13082006@gmail.com>
@HarshitPal25
Copy link
Author

@vikaxsh and @Akshay-datazip i have revert back the changes of the go.mod file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginner easy issues for beginner contributors SWoC26 Social Winter of Code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add Unit Tests for stream_configured.go

5 participants