Skip to content

Conversation

@Beeram12
Copy link

@Beeram12 Beeram12 commented Dec 24, 2025

Description

Fixes #643

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

To test the unit tests run:

  1. go test -v -run TestReformat_ for whole reformat_test.go
  2. go test -v -run TestName for individual tests.

Screenshots or Recordings

Issue.463.1.mp4

Documentation

  • Documentation Link: [link to README, olake.io/docs, or olake-docs]
  • N/A (bug fix, refactor, or test changes only)

Related PR's (If Any):

1) TestGetFirstNotNullType
2) TestReformatValue
@Beeram12 Beeram12 changed the title Add unit tests covering test: Add Unit Tests for reformat.go Dec 24, 2025
1)TestReformatValueOnDataTypes
2)TestReformatRecord
@nayanj98
Copy link
Collaborator

@Beeram12 Can you please rebase you PR to staging from master

@Beeram12 Beeram12 changed the base branch from master to staging December 26, 2025 07:37
@nayanj98
Copy link
Collaborator

nayanj98 commented Jan 2, 2026

@Beeram12 Can you please share a video of how this PR has been tested.

@Beeram12
Copy link
Author

Beeram12 commented Jan 2, 2026

@nayanj98 This is not yet done. So kept it as a draft. But the tests that I have written were tested. I can share the video for those.

@nayanj98
Copy link
Collaborator

nayanj98 commented Jan 2, 2026

@Beeram12 Sure no worries please try to complete your work as soon as possible and when its done just drop a video of the same. Just makes it easy for us to give first review.

@Beeram12
Copy link
Author

Beeram12 commented Jan 2, 2026

@nayanj98 Sure will complete soon and let you know.

@Beeram12 Beeram12 marked this pull request as ready for review January 5, 2026 19:09
@Beeram12
Copy link
Author

Beeram12 commented Jan 5, 2026

@nayanj98 Hey, I have almost covered all functions, but a few are left. I am facing some trouble understanding a few functions like FormatCursorValue and ReformatDate, which deal with time and date. Would like to complete that if someone can help me. Thank you

@Akshay-datazip
Copy link
Collaborator

Akshay-datazip commented Jan 9, 2026

@nayanj98 Hey, I have almost covered all functions, but a few are left. I am facing some trouble understanding a few functions like FormatCursorValue and ReformatDate, which deal with time and date. Would like to complete that if someone can help me. Thank you

Hi, thanks a lot for your contribution and for your patience @Beeram12
Our team is currently a bit constrained on bandwidth, and there are some limitations around documentation availability, so it may take a few days to get back in detail. I’ve already mentioned this on Discord as well.

In the meantime, please feel free to explore other repositories at SWOC . We appreciate your understanding and support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add Unit Tests for reformat.go

3 participants