feat: add unit tests for datatype.go #742
Open
+216
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Unit Tests for datatype.go
Type of Change
ExtractAndMapColumnTypecloses feat: Add Unit Tests for datatype.go #644
Description
This PR adds comprehensive unit tests for
olake/utils/typeutils/datatype.go. The file previously lacked test coverage despite handling critical type detection and comparison logic.During testing, a bug was identified and fixed in
ExtractAndMapColumnTypewhere unknown types were returning an empty string instead oftypes.Unknown.Changes
olake/utils/typeutils/datatype_test.go:TypeFromValue: Verified correcttypes.DataTypereturn for primitives, pointers, slices, maps, and special types.MaximumOnDataType: VerifiedInt64andTimestampcomparisons.detectTimestampPrecision: Verified precision detection (s, ms, us, ns).ExtractAndMapColumnType: Verified SQL type mapping.olake/utils/typeutils/datatype.go:ExtractAndMapColumnTypeto returntypes.Unknownfor missing keys.Verification
golang:1.24-alpineDocker container.