Print error messages on stderr consistently #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
In general, I wouldn't handle errors that way (printing and exiting), but rather raise a custom Python exception. |
wm75
commented
Jul 1, 2020
| end = int(end) | ||
| except Exception: | ||
| print('User Error: invalid start/end coordinate(s)') | ||
| except ValueError: |
Author
There was a problem hiding this comment.
Also note that the try/except won't catch negative values, if that's the intention.
|
This pull request introduces 1 alert and fixes 2 when merging 77e91e7 into 52fd2a1 - view on LGTM.com new alerts:
fixed alerts:
|
wm75
commented
Jul 1, 2020
| if tab is None: | ||
| tab = 1 | ||
| else: | ||
| if int(tab) in [1, 2, 3, 4, 5, 6, 9, 10, 11, 12, 13, 14, 15, 16, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 33]: |
Author
There was a problem hiding this comment.
and do the int conversion outside of the function to avoid the duplicated action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.