Use visited map like a stack to walk full tree (including duplicate pointers)#4
Open
myshkin5 wants to merge 1 commit intodavegardnerisme:masterfrom
Open
Use visited map like a stack to walk full tree (including duplicate pointers)#4myshkin5 wants to merge 1 commit intodavegardnerisme:masterfrom
myshkin5 wants to merge 1 commit intodavegardnerisme:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note the hash will in some cases take longer to calculate with this change. Previously it would never walk a object more than once. But with this change it will never walk the same object more than once per depthwise. The change should use slightly less memory though.
Fixes #3