Graded ! :D #209
Open
Graded ! :D #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, let me say I am very impressed with your guy's app. It is a nice, polished project that I could see having a real impact on real people. Going through it, excepting a few UX hangouts, your app ran smoothly and didn't bug out when I ran it through the testing ringer. The aesthetics and visualizations (besides a lack of units) were clean, useful, and clear. Some of the code could have been more elegant and clearer and the documentation could have used some wor,k but nothing was especially egregious. All in all great work!
Best,
Austin
ps. I would love to hear how spring initiative receives your app
pps. You should get final grades soon once we average both mine and Fillipos' scores