Open
Conversation
Author
|
Just a note, i'm not a react or javascript expert, so please check if there are no problems that i might have missed. :) |
Owner
|
Hmm...this may cause problems since you won't be able to add children outside of content. I'm sure there are some people that hack the scrollbox in this way (I may be one of those people). What might be better is to write pixi-scrollbox as a react component and handle this case directly in the component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've been struggling with including scrollbox into my react-pixi project for quite some time and i finally figured out that the PixiComponent wrapper automatically adds the children into Scrollbox, but in the wrong container. I made this small change to expose the viewport's addChild methods, so that react-pixi would add the children in the proper place.
I think it's safe to do, because the internals of scollbox should not be modified outside anyway and when modifying the code, you can always call super.addChild(...) to add children to scrollbox itself.