Remove global pointer to mdns instance#130
Open
Momomentum wants to merge 1 commit intodavidmoreno:masterfrom
Open
Remove global pointer to mdns instance#130Momomentum wants to merge 1 commit intodavidmoreno:masterfrom
Momomentum wants to merge 1 commit intodavidmoreno:masterfrom
Conversation
Rather than saving a pointer to current mdns instance, pass it through the callback functions and save it in the userdata pointers.
Momomentum
force-pushed
the
remove-mdns-current-hack
branch
from
665d477 to
754d44f
Compare
Contributor
Author
|
@davidmoreno what do you think? |
Owner
|
Hey, thanks! The global was for some weird pointers I was getting long time ago, so I wanted to be sure to use the proper struct. It was before I restructured the mdns code. I will have a better look now, but if it gives no problem, looks perfect for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than saving a pointer to current mdns instance, pass it through the callback functions and save it in the userdata pointers.