Add build options for logger verbosity#137
Closed
Momomentum wants to merge 1 commit intodavidmoreno:masterfrom
Closed
Add build options for logger verbosity#137Momomentum wants to merge 1 commit intodavidmoreno:masterfrom
Momomentum wants to merge 1 commit intodavidmoreno:masterfrom
Conversation
Lets the library consumer define the log level through a cmake cache variable.
Contributor
|
Oh nice! That's what I need too. rtpmidid is running 24/7 on my server trying to connect to my MioXL midi router, that is only powered some hours a day. This spams the syslog. There is also an issue decribed #139 @davidmoreno What do you think? |
Owner
|
Hi, Sorry for the time between updates, I've been busy, but found some time today. I finally rewrote this part as I ddi not like messing with the template parameters. I did two options:
Options for level are debug, info, warning or error. I think for you guys the most interesting would be the config file option. Regards, |
Contributor
|
Sound great. Thank you so much @davidmoreno |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In one of my projects, the log gets quickly filled by debug messages. It would be great if there was a way to let the user configure the log level for app/library.
Here is a proposal for setting log level via cmake, but I could also imagine to set the level at runtime.