-
Notifications
You must be signed in to change notification settings - Fork 5
Upgrade CI runner and tools; add php 8.2-8.4 to test matrix #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bwyu-dayspring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the --prefer-lowest tests are failing for php versions > 8.0. Do you think that is important to fix now?
|
Also - does this PR replace PR #8? |
I bumped the min version of phpunit in the dev dependencies and that solved the failing test cases. |
bwyu-dayspring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
ubuntu-24.04