Skip to content

Conversation

@jwong-dayspring
Copy link

  • Upgrade github runner to ubuntu-24.04
  • Upgrade actions to v4
  • Upgrade composer to v2
  • Add php 8.2-8.4 to test matrix

Copy link

@bwyu-dayspring bwyu-dayspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the --prefer-lowest tests are failing for php versions > 8.0. Do you think that is important to fix now?

@bwyu-dayspring
Copy link

Also - does this PR replace PR #8?

@jwong-dayspring
Copy link
Author

I noticed that the --prefer-lowest tests are failing for php versions > 8.0. Do you think that is important to fix now?

I bumped the min version of phpunit in the dev dependencies and that solved the failing test cases.

@jwong-dayspring
Copy link
Author

Also - does this PR replace PR #8?

No. This is a minimal change to update the CI test cases to include newer versions of PHP. This PR is included in both #8 and #10.

Copy link

@bwyu-dayspring bwyu-dayspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jwong-dayspring jwong-dayspring merged commit a503c47 into master Mar 3, 2025
12 checks passed
@jwong-dayspring jwong-dayspring deleted the update-ci branch March 3, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants