RAiDER v0.5.4 #712
Merged
RAiDER v0.5.4 #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ruff was able to make with `ruff check --fix`
D212 is "no line break at the beginning of a docstring". Conforming to it fully will involve more than what the automatic fix for this category does (it disregards that the description must also be short enough to fit on one line), so I'm choosing to have ruff ignore it for now. Remind me and I'll make a separate issue for this.
Ruff found many more things to change after adding settings to the pyproject.toml. These are the ones it was able to fix automatically.
- Imports sorted
- Quotes """ used in place of apostrophes ''' for docstrings
- Spacing after imports made consistent
- Docstring header consistency (headers are title case with an underline of equals signs and no colon at the end)
- Use of '{}'.format() replaced with f'{}' where possible
- Explicit open() flag 'r' removed as it is the default
- Ensure every docstring description has punctuation - Fixed some typos - Put some comments into imperative mood; will do this for all of them later - Add type annotations where ruff can infer them
- Use double quotes instead of single quotes, except where using double quotes would prevent you from having to escape an apostrophe - Removed unnecessary parentheses - Exactly 2 spaces before a same-line comment - Function calls formatted - Exactly 1 space on either side of an operator (=, +, -, <, etc.) - 1 line between top-of-file docstring and imports - Space before argument type annotation - Space between equals sign in deafult argument - Trailing comma - Exactly 1 empty line at the end of a file - No empty lines at the beginning of a file - Use ".0" instead of "." to denote float literals - One space after a comma - One # for a comment - No extraneous returns
The parentheses in the asserts in test_envVars and test_updateTrue were being interpreted as a set(!), making them always evaluate to True. This was resulting in these tests passing when there was actually something wrong with them. - Asserts fixed to evaluate correctly - Tests fixed to pass fair and square even with the corrected assertions
Two versions of update_yaml existed, the other of which was in tools.RAiDER.aria.prepFromGUNW.py. In order to keep the code clean I extracted the function out to utilFcns.py and redirected imports to point to it instead of the other versions. This function was also linted to use pathlib.Path.
Missing docstrings (D100, D101, D102, D103, D107) ignored for now. Also skipped linting on the GUNW methods that are marked unused. As part of the linting, all functions and methods were given type annotations. This ended up reaching into a few other files, most notably including the GUNW workflow's argument parsing.
ANN101 is adding the type annotation "Self" to every method's self argument. This rule is controversial and in my opinion would be of little benefit for this project. D200 and D205 are both about the exact formatting of docstrings. I am electing not to make any fixes for these rules since it would involve revising so documentation. This could be revisited in the future with project experts' input.
- Added type annotations - Missing docstrings (D100, D101, D102, D103, D107) ignored for now
Use pathlib.Path Use pathlib.Path Use pathlib.Path
Add type annotations Add type annotations Add type annotations Add type annotations Add type annotations Add type annotations Add type annotations Add type annotations Add type annotations
Test update
…l=HRRR and outside HRRR coverage
exit successfully with no changes when run via hyp3 with weather_model=HRRR and outside HRRR coverage
Bumps [ASFHyP3/actions](https://github.com/asfhyp3/actions) from 0.14.0 to 0.17.1. - [Release notes](https://github.com/asfhyp3/actions/releases) - [Changelog](https://github.com/ASFHyP3/actions/blob/develop/CHANGELOG.md) - [Commits](ASFHyP3/actions@v0.14.0...v0.17.1) --- updated-dependencies: - dependency-name: ASFHyP3/actions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Update changelog for v0.5.4 release
pin herbie-data<2025.2.1
Small typo Fix
…P3/actions-0.17.1 Bump ASFHyP3/actions from 0.14.0 to 0.17.1
Contributor
|
No concerns on my end. I'm not a maintainer so someone else will have to be accountable for the formal review. |
Collaborator
🤔 do you want to be? ;-) |
jhkennedy
approved these changes
Feb 28, 2025
Contributor
I'm leaning no. I'm happy to contribute features but I don't think I have the bandwidth to accountable for the health of the application as a whole. |
jhkennedy
added
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
prepFromGunw.check_weather_model_availabilitynow returnsFalsefor HRRR when outside the CONUS or AK coverage areas, rather than raising ValueError. As a result, HRRR jobs run via HyP3 for GUNWs outside HRRR coverage will exit successfully without making any changes to the GUNW.Fixes
#700 - Fixed a few path typos and handle some edge cases
#679 - Fixed a bug causing test_updateTrue to falsely pass.
#679 - Fixed a global bbox bug in checkContainment
Changed
#701 - Fixed a few path typos and handle some edge cases, add unit tests, lint project
#672 - Linted the project with ruff.
#683 - Fixed a naive datetime and added default template to template generation argument