Skip to content

Conversation

@sssangha
Copy link
Collaborator

Added support within the raiderCombine.py pipeline to support temporal subsetting, which is introduced as a new option --timeinterval.

If a valid argument is provided, temporal sampling is performed in 2 phases:

  1. With a 1 day buffer encompassing the specified --timeinterval in order to not lose valid observations due to time zone changes.
  2. With the explicit specified --timeinterval once 'Localtime' has been computed

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Updated filtering conditions to use 'Localtime' for date range checks.
Added entry for temporal subsetting in raiderCombine.py and other updates.
@sssangha sssangha marked this pull request as ready for review January 15, 2026 02:53
@sssangha sssangha requested a review from jlmaurer January 15, 2026 02:53
raider_folder: Path
gnss_folder: Path
raider_folder: List[Path]
gnss_folder: List[Path]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sssangha could this be Union[List[Path], Path]?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the logic more consistent overall in the code, but the logic is as follows:

  • Support wildcard/multiple path input in the parser
  • Split into a list discrete individual paths and push them through as individual paths through the downstream function.

I verified the outputs I get now vs before this little clean-up are consistent though, so the files are being pushed through as we'd expect.

Updated the environment.yml file to include 'geopandas' and 'pyogrio' as dependencies, and modified the update command to use the '--prune' option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants