Skip to content

Conversation

@dblock
Copy link
Owner

@dblock dblock commented Jan 5, 2026

Migrates the project from Travis CI to GitHub Actions.

  • Adds .github/workflows/test.yml with Ruby test workflow
  • Adds .github/workflows/rubocop.yml with RuboCop linting workflow
  • Adds .github/workflows/danger.yml with danger-pr-comment workflow for PR comments
  • Removes .travis.yml
  • Updates README.md to reflect GitHub Actions CI status badge
  • Updates CHANGELOG.md with PR reference

Both test and RuboCop workflows run on all branches and pull requests using Ruby 3.4.

dblock added a commit that referenced this pull request Jan 5, 2026
@dblock dblock force-pushed the migrate-danger-pr-comment branch 3 times, most recently from a2bcf31 to 2786068 Compare January 5, 2026 19:06
Co-authored-by: GitHub Copilot <noreply@github.com>
@dblock dblock force-pushed the migrate-danger-pr-comment branch from 2786068 to cb20a5c Compare January 5, 2026 19:08
@dblock
Copy link
Owner Author

dblock commented Jan 5, 2026

@copilot check this out?

Copy link

Copilot AI commented Jan 5, 2026

@dblock I've opened a new pull request, #46, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the project's continuous integration from Travis CI to GitHub Actions, implementing a more modern CI/CD approach with separate workflows for testing, linting, and pull request automation.

Key Changes:

  • Replaced Travis CI with three GitHub Actions workflows: test (runs RSpec tests), RuboCop (linting), and Danger (PR automation with danger-pr-comment)
  • Updated dependencies by adding danger-pr-comment gem and removing version constraints from danger-changelog and danger-toc
  • Updated Dangerfile to use danger-pr-comment plugin and stricter check methods (check!)

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/test.yml Adds test workflow to run RSpec tests on Ruby 3.4
.github/workflows/rubocop.yml Adds RuboCop linting workflow on Ruby 3.4
.github/workflows/danger.yml Adds Danger workflow using danger-pr-comment reusable workflow
.github/workflows/danger-comment.yml Adds workflow to post Danger comments after PR validation
Gemfile Adds danger-pr-comment gem and removes version constraints from danger-changelog and danger-toc
Dangerfile Updates to import danger-pr-comment and uses stricter check! methods
README.md Updates CI badge from Travis CI to GitHub Actions test workflow
CHANGELOG.md Documents the migration in the changelog
.travis.yml Removes Travis CI configuration file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


gem 'danger-changelog', '~> 0.4.0'
gem 'danger-toc', '~> 0.1'
gem 'danger'
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'danger' gem is added without a version constraint. Consider adding a version constraint for better dependency management and reproducibility, similar to how other gems in the Gemfile specify versions (e.g., 'rspec', 'rubocop').

Suggested change
gem 'danger'
gem 'danger', '~> 9.0'

Copilot uses AI. Check for mistakes.
Comment on lines +6 to +8
gem 'danger-changelog'
gem 'danger-pr-comment', '0.1.0'
gem 'danger-toc'
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version constraints were removed from 'danger-changelog' (previously '> 0.4.0') and 'danger-toc' (previously '> 0.1'). This could lead to unexpected behavior if newer versions introduce breaking changes. Consider retaining version constraints for stability and reproducibility.

Suggested change
gem 'danger-changelog'
gem 'danger-pr-comment', '0.1.0'
gem 'danger-toc'
gem 'danger-changelog', '~> 0.4.0'
gem 'danger-pr-comment', '0.1.0'
gem 'danger-toc', '~> 0.1'

Copilot uses AI. Check for mistakes.
@dblock dblock merged commit d23bd66 into master Jan 5, 2026
12 checks passed
@dblock dblock deleted the migrate-danger-pr-comment branch January 5, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants