-
-
Notifications
You must be signed in to change notification settings - Fork 180
Migrate from Travis CI to GitHub Actions with danger-pr-comment workflow. #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a2bcf31 to
2786068
Compare
Co-authored-by: GitHub Copilot <noreply@github.com>
2786068 to
cb20a5c
Compare
|
@copilot check this out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the project's continuous integration from Travis CI to GitHub Actions, implementing a more modern CI/CD approach with separate workflows for testing, linting, and pull request automation.
Key Changes:
- Replaced Travis CI with three GitHub Actions workflows: test (runs RSpec tests), RuboCop (linting), and Danger (PR automation with danger-pr-comment)
- Updated dependencies by adding danger-pr-comment gem and removing version constraints from danger-changelog and danger-toc
- Updated Dangerfile to use danger-pr-comment plugin and stricter check methods (check!)
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test.yml | Adds test workflow to run RSpec tests on Ruby 3.4 |
| .github/workflows/rubocop.yml | Adds RuboCop linting workflow on Ruby 3.4 |
| .github/workflows/danger.yml | Adds Danger workflow using danger-pr-comment reusable workflow |
| .github/workflows/danger-comment.yml | Adds workflow to post Danger comments after PR validation |
| Gemfile | Adds danger-pr-comment gem and removes version constraints from danger-changelog and danger-toc |
| Dangerfile | Updates to import danger-pr-comment and uses stricter check! methods |
| README.md | Updates CI badge from Travis CI to GitHub Actions test workflow |
| CHANGELOG.md | Documents the migration in the changelog |
| .travis.yml | Removes Travis CI configuration file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| gem 'danger-changelog', '~> 0.4.0' | ||
| gem 'danger-toc', '~> 0.1' | ||
| gem 'danger' |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'danger' gem is added without a version constraint. Consider adding a version constraint for better dependency management and reproducibility, similar to how other gems in the Gemfile specify versions (e.g., 'rspec', 'rubocop').
| gem 'danger' | |
| gem 'danger', '~> 9.0' |
| gem 'danger-changelog' | ||
| gem 'danger-pr-comment', '0.1.0' | ||
| gem 'danger-toc' |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version constraints were removed from 'danger-changelog' (previously '> 0.4.0') and 'danger-toc' (previously '> 0.1'). This could lead to unexpected behavior if newer versions introduce breaking changes. Consider retaining version constraints for stability and reproducibility.
| gem 'danger-changelog' | |
| gem 'danger-pr-comment', '0.1.0' | |
| gem 'danger-toc' | |
| gem 'danger-changelog', '~> 0.4.0' | |
| gem 'danger-pr-comment', '0.1.0' | |
| gem 'danger-toc', '~> 0.1' |
Migrates the project from Travis CI to GitHub Actions.
Both test and RuboCop workflows run on all branches and pull requests using Ruby 3.4.