Fix prevBtnClass + nextBtnClass configuration options#18
Open
brandur wants to merge 1 commit intodbrekalo:masterfrom
Open
Fix prevBtnClass + nextBtnClass configuration options#18brandur wants to merge 1 commit intodbrekalo:masterfrom
prevBtnClass + nextBtnClass configuration options#18brandur wants to merge 1 commit intodbrekalo:masterfrom
Conversation
Currently, there isn't enough spacing between the default CSS classes for the next and previous buttons and a potential custom one, so if you use of them, the class names get truncated together and stop working like so: ``` html <button ... class="next slbArrowmyCustomClass"> ``` They should look like what the `closeBtnClass` above has with an extra trailing space so that all classes appear correctly separated like so: ``` html <button ... class="next slbArrow myCustomClass"> ``` Note: I didn't regenerate anything in `dist/` (honestly, not sure how to off hand), so this just comes into what's in `src/`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there isn't enough spacing between the default CSS classes
for the next and previous buttons and a potential custom one, so if you
use of them, the class names get truncated together and stop working
like so:
They should look like what the
closeBtnClassabove has with an extratrailing space so that all classes appear correctly separated like so:
Note: I didn't regenerate anything in
dist/(honestly, not sure howto off hand), so this just comes into what's in
src/.