Skip to content

Comments

search_tags fails#70

Merged
dbrgn merged 1 commit intomasterfrom
fix_search_tags
Jan 12, 2016
Merged

search_tags fails#70
dbrgn merged 1 commit intomasterfrom
fix_search_tags

Conversation

@dbrgn
Copy link
Owner

@dbrgn dbrgn commented Jan 12, 2016

I started using orochi today but I noticed (using py3.5) that the search_tags command seems not to work as advertised:

(8tracks)> search_tags night, sleep
Traceback (most recent call last):
  File ".../venv/bin/orochi", line 11, in <module>
    sys.exit(main())
  File ".../venv/lib/python3.5/site-packages/orochi/client.py", line 748, in main
    client.cmdloop()
  File ".../venv/lib/python3.5/site-packages/orochi/client.py", line 178, in cmdloop
    super(Client, self).cmdloop()
  File "/usr/lib/python3.5/cmd.py", line 138, in cmdloop
    stop = self.onecmd(line)
  File "/usr/lib/python3.5/cmd.py", line 217, in onecmd
    return func(arg)
  File ".../venv/lib/python3.5/site-packages/orochi/client.py", line 230, in do_search_tags
    mixes = self.search_request(s, 'tag')
  File ".../venv/lib/python3.5/site-packages/orochi/client.py", line 436, in search_request
    self.config['results_sorting'], self._search_results_page, self._results_per_page)
  File ".../venv/lib/python3.5/site-packages/orochi/api.py", line 162, in search_mix
    if len(tags) < 1:
TypeError: object of type 'filter' has no len()

I recon the issue comes from around here: https://github.com/dbrgn/orochi/blob/master/orochi/api.py#L164

@dbrgn
Copy link
Owner

dbrgn commented Jan 12, 2016

I can confirm that, it's probably a leftover from the Python 3 port (#59). Thanks a lot for the report!

@dbrgn dbrgn added the bug label Jan 12, 2016
@dbrgn
Copy link
Owner

dbrgn commented Jan 12, 2016

This should fix it.

@dbrgn dbrgn self-assigned this Jan 12, 2016
dbrgn added a commit that referenced this pull request Jan 12, 2016
@dbrgn dbrgn merged commit c835645 into master Jan 12, 2016
@dbrgn dbrgn deleted the fix_search_tags branch January 12, 2016 14:10
@dbrgn
Copy link
Owner

dbrgn commented Jan 12, 2016

Thanks @satreix for reporting. I'll do a new minor release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant