Conversation
This was recently released
bd15afa to
23188eb
Compare
83ff4e0 to
353f28b
Compare
This avoids accidentally using the system libraries rather than the locally built ones.
353f28b to
8b5f319
Compare
matt-sheets
approved these changes
Feb 27, 2025
| #!/bin/bash | ||
|
|
||
| set -e -u -o pipefail | ||
| set -e -u -x -o pipefail |
Collaborator
There was a problem hiding this comment.
Did you want to leave the -x in? Same comment for test.sh
Owner
Author
There was a problem hiding this comment.
Yeah, I was a little surprised they weren't in already, because it's always helpful for debugging CI failures. I feel like the cost is low and the value is high for having the additional debug insight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was recently released