Skip to content

Conversation

@jenniemeier
Copy link
Collaborator

Added missing links, slight grammar formatting, unwrapping of long lines.

Added missing links, slight grammar formatting, unwrapping of long lines.
Copy link
Collaborator

@parasyte parasyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... unwrapping of long lines.

Unless I am terribly mistaken, this change wraps long lines at a specific character column into multiple short lines. Unwrapping would be the opposite, combining multiple short lines into one long line.

I strongly prefer UNwrapping, which is opposite of what this PR is doing. The diff is impossible to read at a glance with hard-wrapped lines. And it is not what I had in mind for #286 (comment)

For that reason, I'm going to say no to this change. I might be vetoed, but this is a big readability issue for change tracking.

@jenniemeier
Copy link
Collaborator Author

@parasyte apologies for the misunderstanding! I believe @rxgrant has opened a discussion on this to determine a policy, so I'll await further instruction before we do anything more on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants