refactor(cli, mcp): use HashSet for active MCP server IDs
#388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the MCP server configuration logic to use a `HashSet` instead of a `Vec` when identifying active servers. This change ensures that each unique MCP server is only processed once, preventing potential duplicate connections. The `run_services` method in `jp_mcp` now accepts an owned `HashSet`, reducing the need for explicit cloning during the service startup loop. Additionally, this commit fixes a logging bug in the MCP environment variable loader by correctly using `inspect_err` and formatting the error output. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the MCP server configuration logic to use a
HashSetinstead of aVecwhen identifying active servers. This change ensures that each unique MCP server is only processed once, preventing potential duplicate connections.The
run_servicesmethod injp_mcpnow accepts an ownedHashSet, reducing the need for explicit cloning during the service startup loop. Additionally, this commit fixes a logging bug in the MCP environment variable loader by correctly usinginspect_errand formatting the error output.