fix(config): Use correct Deserialize impl for enums
#389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the latest version of `schematic`, untagged enums have a custom `Deserialize` implementation that conflicts with our `with` attributes. The new `skip_custom_untagged_enum_deserialize_impl` attribute ensures our `with` attributes are used instead. Additionally, the new `literal` attribute makes sure that `schematic`'s schema generation uses string literals for enum variants, as opposed to the default `null` for unit variants in enums. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the latest version of
schematic, untagged enums have a customDeserializeimplementation that conflicts with ourwithattributes. The newskip_custom_untagged_enum_deserialize_implattribute ensures ourwithattributes are used instead.Additionally, the new
literalattribute makes sure thatschematic's schema generation uses string literals for enum variants, as opposed to the defaultnullfor unit variants in enums.