Fixes to inch/mm detection#3
Open
MitchBradley wants to merge 2 commits intodchote:masterfrom
MitchBradley:master
Open
Fixes to inch/mm detection#3MitchBradley wants to merge 2 commits intodchote:masterfrom MitchBradley:master
MitchBradley wants to merge 2 commits intodchote:masterfrom
MitchBradley:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug with inch/mm detection that I introduced with my ijkabsolute patch. The root cause was a variable scoping problem. There used to be two copies of isUnitsMm, one in the parser object and another in an object in an outer scope. After parsing, the parser member variable was copied into the outer object. With the new code structure, it is difficult to access the parser object from the individual gcode handler functions. The solution is to eliminate the parser-specific member variable, now doing all units fiddling directly on the isUnitsMm member of the outer object.