Skip to content

Conversation

@wayfarer3130
Copy link
Contributor

If you run dcm4che imageio opencv decompression under JDK >=11, you get a lot of error messages about reflection becoming illegal shortly and being disallowed. The changes attached fix this as long as you implement the appropriate methods to get the path name and/or random access file object on the response.

@nroduit
Copy link
Member

nroduit commented Dec 20, 2021

See my comment

@wayfarer3130
Copy link
Contributor Author

@gunterze - what is your opinion on the change here. I can add supporting unit tests to make the quality gate pass, but I mean on the underlying issue. My thought is that the code shouldn't rely on special java allow internal access flags to enable it to work, but should work on public methods, which is what I modified the code to do.
@nroduit - I know you said that there is a longer term change to just be able to direct read from the IIS, but in the meantime, how do you feel about having the extra implementations to allow it to work without the forbidden reflection.

@wayfarer3130 wayfarer3130 force-pushed the fix/reflect_error_newer_java branch from d1c44a6 to a61fd5f Compare January 6, 2022 18:53
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants