Skip to content

Conversation

@HenrikHL
Copy link
Contributor

@HenrikHL HenrikHL commented Jan 4, 2026

DT-2666: Support 12-digit HS codes and 16-digit nationalCommodityCode

Because of backward compatibility issues - a new NationalCommodityCode object called ExtendedNationalCommodityCode needed to be created and linked to.
Because HSCodes sometimes is a mandatory property - it needs to be provided at the same time as ExtendedHSCodes

@qodo-code-review
Copy link

qodo-code-review bot commented Jan 4, 2026

PR Compliance Guide 🔍

(Compliance updated until commit 0f4b9df)

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟡
🎫 #SD-2666
🟢 Add new field `extendedHSCodes` to support up to 12 characters.
Deprecate existing fields HSCodes and nationalCommodityCode.value (kept for backward
compatibility but clearly marked as deprecated).
Apply the change to both Booking and eBL (SI, TD, ISSU, PINT) standards.
🔴 Add new field `nationalCommodityCode.extendedValue` to support up to 16 characters.
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

🔴
Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: 🏷️
Documentation typos: Multiple newly added descriptions contain the misspelling "presendence"
(intended "precedence"), reducing clarity and self-documentation of the API
behavior.

Referred Code
  deprecated: true
  description: |
    A list of `National Commodity Codes` that apply to this `consignmentItem`

    **DEPRECATED:** This property is not to be used any more, please use `extendedNationalCommodityCodes` instead. If both `nationalCommodityCodes` and `extendedNationalCommodityCodes` are provided then `extendedNationalCommodityCodes` takes presendence and `nationalCommodityCodes` must be ignored.
  items:
    $ref: '#/components/schemas/NationalCommodityCode'
extendedNationalCommodityCodes:
  type: array
  description: |
    A list of `National Commodity Codes` that apply to this `consignmentItem`. The `extendedNationalCommodityCodes` support up to 16 character codes.

    **Note:** If both `nationalCommodityCodes` and `extendedNationalCommodityCodes` are provided then `extendedNationalCommodityCodes` takes precedence and `nationalCommodityCodes` must be ignored.
  items:

Learn more about managing compliance generic rules or creating your own custom rules

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Previous compliance checks

Compliance check up to commit 861f15f
Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟡
🎫 #SD-2666
🟢 Add a new extendedHSCodes field that supports HS codes up to 12 characters (without
changing existing maxLength in a patch release).
🔴 Add a new field nationalCommodityCode.extendedValue supporting up to 16 characters
(without changing existing maxLength in a patch release).
Deprecate existing HSCodes and nationalCommodityCode.value (kept for backward
compatibility, clearly marked deprecated).
Apply the change to both Booking and eBL standards (SI, TD, ISS, PINT).
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

🔴
Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status:
Documentation typos: Multiple new schema descriptions contain misspellings (e.g., "backward
compatability", "presedence", "charactrers") which reduces
clarity and self-documentation of the API specification.

Referred Code
    **DEPRECATED:** Because of backward compatability it is required to provide a value in this property even though a value is provided in the `extendedHSCodes` property. In case both properties are provided (`extendedHSCodes` and `HSCodes`) - `HSCodes` must be ignored.
  items:
    type: string
    pattern: ^\d{6,10}$
    minLength: 6
    maxLength: 10
    description: |
      Used by customs to classify the product being shipped. The type of HS code depends on country and customs requirements. The code must be at least 6 and at most 10 digits.

      More information can be found here: [HS Nomenclature](https://www.wcoomd.org/en/topics/nomenclature/instrument-and-tools).
    example: '851713'
extendedHSCodes:
  type: array
  description: |
    A list of `HS Codes` that apply to this `consignmentItem`. The `extendedHSCodes` support up to 12 character codes.

    **Note:** If `extendedHSCodes` is provided - it always takes presedence over `HSCodes` (which is a required property but must be ignored).
  items:
    type: string
    pattern: ^\d{6,12}$
    minLength: 6


 ... (clipped 176 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
Audit logging not shown: This PR only updates OpenAPI specifications/examples, so there is no visible evidence that
critical actions are logged with user ID, timestamp, action description, and outcome.

Referred Code
application/json:
  schema:
    $ref: '#/components/schemas/EblEnvelope'
  examples:
    regularSTDExample:
      summary: |
        Endorsing a Transport Document with regular Dry cargo
      description: |
        A **Transport Document** being sent.

        **Note:** The `envelopeManifestSignedContent` and `envelopeTransferChain` are not computed values but rather random strings (this example cannot be used as is).
      value:
        transportDocument:
          transportDocumentReference: 62CD536BA8D34C469AFD
          shippingInstructionsReference: fc5009a7-25ad-4bb0-9892-4e2dea6bcdd9
          transportDocumentStatus: DRAFT
          transportDocumentTypeCode: BOL
          isShippedOnBoardType: true
          freightPaymentTermCode: PRE
          isElectronic: true
          isToOrder: true


 ... (clipped 471 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status:
Logging not assessable: The PR changes are limited to API specs/examples and do not show any application logging
behavior, so it cannot be verified that logs are structured and free of sensitive data.

Referred Code
application/json:
  schema:
    $ref: '#/components/schemas/IssuanceRequest'
  examples:
    regularSTDExample:
      summary: |
        Issuing a Transport Document with regular Dry cargo
      description: |
        A **Transport Document** being issued.

        **Note:** The `content` in the `eBLVisualisationByCarrier` and `issuanceManifestSignedContent` are not "real" values but rather random strings (this example cannot be used as is).
      value:
        document:
          transportDocumentReference: 62CD536BA8D34C469AFD
          shippingInstructionsReference: fc5009a7-25ad-4bb0-9892-4e2dea6bcdd9
          transportDocumentStatus: DRAFT
          transportDocumentTypeCode: BOL
          isShippedOnBoardType: true
          freightPaymentTermCode: PRE
          isElectronic: true
          isToOrder: true


 ... (clipped 251 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
Full security not visible: While the spec adds regex/length constraints for the new extended code fields, the diff
does not provide enough context to verify end-to-end validation/sanitization and
authn/authz enforcement in the actual implementation.

Referred Code
extendedHSCodes:
  type: array
  description: |
    A list of `HS Codes` that apply to this `consignmentItem`. The `extendedHSCodes` support up to 12 character codes.

    **Note:** If `extendedHSCodes` is provided - it always takes presedence over `HSCodes` (which is a required property but must be ignored).
  items:
    type: string
    pattern: ^\d{6,12}$
    minLength: 6
    maxLength: 12
    description: |
      Used by customs to classify the product being shipped. The type of HS code depends on country and customs requirements. The code must be at least 6 and at most 12 digits.

      More information can be found here: [HS Nomenclature](https://www.wcoomd.org/en/topics/nomenclature/instrument-and-tools).
    example: '851713'
nationalCommodityCodes:
  type: array
  deprecated: true
  description: |
    A list of `National Commodity Codes` that apply to this `consignmentItem`


 ... (clipped 279 lines)

Learn more about managing compliance generic rules or creating your own custom rules

@qodo-code-review
Copy link

qodo-code-review bot commented Jan 4, 2026

PR Code Suggestions ✨

Latest suggestions up to 0f4b9df

CategorySuggestion                                                                                                                                    Impact
Possible issue
Prevent empty code arrays

Add minItems: 1 to the extendedHSCodes schema to prevent empty arrays and ensure
it contains at least one code, mirroring the constraint of the deprecated
HSCodes field.

ebl/v3/EBL_v3.0.3.yaml [5990-6005]

 extendedHSCodes:
   type: array
+  minItems: 1
   description: |
     A list of `HS Codes` that apply to this `consignmentItem`. The `extendedHSCodes` support up to 12 character codes.
     
     **Note:** If `extendedHSCodes` is provided - it always takes precedence over `HSCodes` (which is a required property but must be ignored).
   items:
     type: string
     pattern: ^\d{6,12}$
     minLength: 6
     maxLength: 12
     description: |
       Used by customs to classify the product being shipped. The type of HS code depends on country and customs requirements. The code must be at least 6 and at most 12 digits.
 
       More information can be found here: [HS Nomenclature](https://www.wcoomd.org/en/topics/nomenclature/instrument-and-tools).
     example: '851713'
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly points out that extendedHSCodes should not be an empty array, and adding minItems: 1 makes it consistent with the field it replaces (HSCodes), improving data validation.

Medium
Require country linkage field

Make the countryCode field required in the NationalCommodityCode schema to align
with its description and ensure data consistency.

bkg/v2/BKG_v2.0.4.yaml [5894-5951]

 NationalCommodityCode:
   type: object
   title: National Commodity Code
   deprecated: true
   description: |
     The national commodity classification code linked to a country with a value.
 
     An example could look like this:
 
     | Type  | Country | Value |
     |-------|:-------:|-------------|
     |NCM|BR|['1515', '2106', '2507', '2512']|
 
     **DEPRECATED:** This object is not to be used any more, please use `ExtendedNationalCommodityCode` instead.
   properties:
     type:
       type: string
       pattern: ^\S(?:.*\S)?$
     countryCode:
       type: string
       pattern: ^[A-Z]{2}$
       minLength: 2
       maxLength: 2
     values:
       type: array
       minItems: 1
       description: |
         A list of `national commodity codes` values.
       items:
         type: string
         pattern: ^\S(?:.*\S)?$
         maxLength: 10
         description: |
           The value of the `National Commodity Code`
         example: '1515'
       example:
         - '1515'
         - '2106'
         - '2507'
         - '2512'
   required:
     - type
+    - countryCode
     - values
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies an inconsistency where countryCode is not required, despite the description implying it is, and proposes a fix that improves schema integrity.

Low
General
Clarify legacy field deprecation

Deprecate the nationalCommodityCode field and add a description clarifying that
extendedNationalCommodityCode takes precedence, mirroring the pattern used for
their array-based counterparts.

ebl/v3/EBL_v3.0.3.yaml [6203-6206]

 nationalCommodityCode:
+  deprecated: true
+  description: |
+    The national commodity classification code linked to a country with a value.
+
+    **DEPRECATED:** This property is not to be used any more, please use `extendedNationalCommodityCode` instead. If both `nationalCommodityCode` and `extendedNationalCommodityCode` are provided then `extendedNationalCommodityCode` takes precedence and `nationalCommodityCode` must be ignored.
   $ref: '#/components/schemas/NationalCommodityCode'
 extendedNationalCommodityCode:
   $ref: '#/components/schemas/ExtendedNationalCommodityCode'
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly identifies that the single-item nationalCommodityCode was not deprecated like its array counterpart, and applying the deprecation improves consistency and clarity.

Medium
Incremental [*]
Standardize deprecation precedence note

Standardize the deprecation note for extendedNationalCommodityCodes to ensure
consistency with other definitions, and correct any "presendence" misspellings.

ebl/v3/EBL_v3.0.3.yaml [6020]

+**Note:** If both `nationalCommodityCodes` and `extendedNationalCommodityCodes` are provided then `extendedNationalCommodityCodes` takes precedence and `nationalCommodityCodes` must be ignored.
 
-
  • Apply / Chat
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly points out that the deprecation note on line 6020 is different from similar notes in other files, and standardizing it would improve consistency.

Low
Clarify precedence note wording

Revise the precedence note for extendedHSCodes to use a consistent,
non-hyphenated sentence, ensuring the "extended wins, legacy ignored" rule is
explicit and unambiguous.

ebl/v3/issuance/EBL_ISS_v3.0.3.yaml [1296]

-**Note:** If `extendedHSCodes` is provided - it always takes precedence over `HSCodes` (which is a required property but must be ignored).
+**Note:** If `extendedHSCodes` is provided, it takes precedence over `HSCodes` (which is a required legacy property but MUST be ignored).
  • Apply / Chat
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly identifies that the wording of the precedence note on line 1296 is inconsistent with other similar notes, and standardizing it would improve clarity.

Low
  • Update

Previous suggestions

✅ Suggestions up to commit 861f15f
CategorySuggestion                                                                                                                                    Impact
High-level
Simplify backward compatibility for HSCodes

To simplify the API, make the deprecated HSCodes field optional instead of
required. This change would allow new clients to use only the new
extendedHSCodes field, improving the developer experience.

Examples:

ebl/v3/EBL_v3.0.3.yaml [5975-5979]
          deprecated: true
          description: |
            A list of `HS Codes` that apply to this `consignmentItem`.

            **DEPRECATED:** Because of backward compatability it is required to provide a value in this property even though a value is provided in the `extendedHSCodes` property. In case both properties are provided (`extendedHSCodes` and `HSCodes`) - `HSCodes` must be ignored.
pint/v3/EBL_PINT_v3.0.0.yaml [2031-2035]
          deprecated: true
          description: |
            A list of `HS Codes` that apply to this `consignmentItem`.

            **DEPRECATED:** Because of backward compatability it is required to provide a value in this property even though a value is provided in the `extendedHSCodes` property. In case both properties are provided (`extendedHSCodes` and `HSCodes`) - `HSCodes` must be ignored.

Solution Walkthrough:

Before:

# In EBL_v3.0.3.yaml
ConsignmentItemCarrierClause:
  allOf:
    - ...
    - type: object
      required:
        - carrierBookingReference
        - descriptionOfGoods
        - HSCodes # Deprecated but still required
      properties:
        HSCodes:
          deprecated: true
          description: |
            **DEPRECATED:** Because of backward compatability it is required to provide a value in this property...
        extendedHSCodes:
          # ... new optional field

After:

# In EBL_v3.0.3.yaml
ConsignmentItemCarrierClause:
  allOf:
    - ...
    - type: object
      required:
        - carrierBookingReference
        - descriptionOfGoods
        # HSCodes is now optional
      properties:
        HSCodes:
          deprecated: true
          description: |
            **DEPRECATED:** This property is not to be used any more, please use `extendedHSCodes` instead.
        extendedHSCodes:
          # ... new optional field
Suggestion importance[1-10]: 8

__

Why: The suggestion correctly identifies that requiring clients to send a deprecated HSCodes field is cumbersome and proposes a valid, non-breaking simplification that improves the API design.

Medium
Possible issue
Make countryCode required and fix typo
Suggestion Impact:The commit fixes the description typo ("charactrers" -> "characters") but does not make countryCode required.

code diff:

@@ -2188,7 +2188,7 @@
       type: object
       title: National Commodity Code (Extended)
       description: |
-        Extended version of the national commodity classification code linked to a country with a value supporting up to 16 charactrers.
+        Extended version of the national commodity classification code linked to a country with a value supporting up to 16 characters.

In ExtendedNationalCommodityCode, make the countryCode property required to
match its description and fix a typo from "charactrers" to "characters".

pint/v3/EBL_PINT_v3.0.0.yaml [2187-2241]

     ExtendedNationalCommodityCode:
       type: object
   title: National Commodity Code (Extended)
   description: |2
-        Extended version of the national commodity classification code linked to a country with a value supporting up to 16 charactrers.
+        Extended version of the national commodity classification code linked to a country with a value supporting up to 16 characters.
 ...
       required:
         - type
+        - countryCode
         - values
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly points out that countryCode should be required for data integrity, aligning with the object's description, and also fixes a typo in the description.

Low
Enforce non-empty extendedHSCodes array

Add a minItems: 1 constraint to the extendedHSCodes schema to prevent it from
being an empty list.

pint/v3/EBL_PINT_v3.0.0.yaml [2046-2061]

 extendedHSCodes:
   type: array
+  minItems: 1
   description: |
     A list of `HS Codes` that apply to this `consignmentItem`. The `extendedHSCodes` support up to 12 character codes.
     
     **Note:** If `extendedHSCodes` is provided - it always takes presedence over `HSCodes` (which is a required property but must be ignored).
   items:
     type: string
     pattern: ^\d{6,12}$
     minLength: 6
     maxLength: 12
     description: |
       Used by customs to classify the product being shipped. The type of HS code depends on country and customs requirements. The code must be at least 6 and at most 12 digits.
   example: '851713'
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly proposes adding minItems: 1 to prevent empty arrays, which improves data validation and consistency, especially since the deprecated HSCodes field has this constraint.

Low
Require at least one extendedNationalCommodityCode

Add a minItems: 1 constraint to the extendedNationalCommodityCodes schema to
prevent the array from being empty.

pint/v3/EBL_PINT_v3.0.0.yaml [2071-2078]

 extendedNationalCommodityCodes:
   type: array
+  minItems: 1
   description: |
     A list of `National Commodity Codes` that apply to this `consignmentItem`. The `extendedNationalCommodityCodes` support up to 16 character codes.
     
     **Note:** If both `nationalCommodityCodes` and `extendedNationalCommodityCodes` are provided then `extendedNationalCommodityCodes` takes presedence and `nationalCommodityCodes` must be ignored.
   items:
     $ref: '#/components/schemas/ExtendedNationalCommodityCode'
Suggestion importance[1-10]: 5

__

Why: The suggestion correctly proposes adding minItems: 1 to prevent empty arrays, which improves data validation and consistency with similar fields in the API.

Low
Fix typo in deprecation notice
Suggestion Impact:Updated the deprecation notice text to reference `extendedNationalCommodityCodes` instead of the incorrect `extendedHSCodes`, matching the suggested correction.

code diff:

@@ -5638,7 +5638,7 @@
           description: |
             A list of `National Commodity Codes` that apply to this `commodity`
 
-            **DEPRECATED:** This property is not to be used any more, please use `extendedNationalCommodityCodes` instead. If both `nationalCommodityCodes` and `extendedHSCodes` are provided then `extendedNationalCommodityCodes` takes presendence and `nationalCommodityCodes` must be ignored.
+            **DEPRECATED:** This property is not to be used any more, please use `extendedNationalCommodityCodes` instead. If both `nationalCommodityCodes` and `extendedNationalCommodityCodes` are provided then `extendedNationalCommodityCodes` takes presendence and `nationalCommodityCodes` must be ignored.

Correct a typo in the deprecation notice for nationalCommodityCodes by replacing
extendedHSCodes with extendedNationalCommodityCodes to clarify precedence.

bkg/v2/BKG_v2.0.4.yaml [5638-5641]

 description: |2
       A list of `National Commodity Codes` that apply to this `commodity`
 
-      **DEPRECATED:** This property is not to be used any more, please use `extendedNationalCommodityCodes` instead. If both `nationalCommodityCodes` and `extendedHSCodes` are provided then `extendedNationalCommodityCodes` takes presendence and `nationalCommodityCodes` must be ignored.
+      **DEPRECATED:** This property is not to be used any more, please use `extendedNationalCommodityCodes` instead. If both `nationalCommodityCodes` and `extendedNationalCommodityCodes` are provided then `extendedNationalCommodityCodes` takes presendence and `nationalCommodityCodes` must be ignored.

[Suggestion processed]

Suggestion importance[1-10]: 4

__

Why: The suggestion correctly identifies and fixes a typo in a deprecation notice where extendedHSCodes was used instead of extendedNationalCommodityCodes, improving the clarity of the API documentation.

Low
General
Remove redundant length constraints

Remove the redundant minLength and maxLength properties from the extendedHSCodes
item schema, as the pattern already enforces the length constraint.

pint/v3/EBL_PINT_v3.0.0.yaml [2046-2056]

     extendedHSCodes:
       type: array
   description: |2
         A list of `HS Codes` that apply to this `consignmentItem`. The `extendedHSCodes` support up to 12 character codes.
         
         **Note:** If `extendedHSCodes` is provided - it always takes presedence over `HSCodes` (which is a required property but must be ignored).
       items:
         type: string
         pattern: ^\d{6,12}$
-        minLength: 6
-        maxLength: 12
Suggestion importance[1-10]: 2

__

Why: The suggestion correctly identifies redundant minLength and maxLength properties but removing them offers only a minor simplification to the schema with no functional impact.

Low

@HenrikHL HenrikHL requested a review from Copilot January 5, 2026 07:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends support for HS codes from 10 to 12 digits and national commodity codes from an unspecified length to 16 characters, addressing ticket DT-2666. To maintain backward compatibility, new properties (extendedHSCodes and extendedNationalCommodityCodes) and a new schema (ExtendedNationalCommodityCode) are introduced while deprecating the original ones.

Key changes:

  • Introduced extendedHSCodes property supporting 6-12 digit codes (vs. original 6-10)
  • Created ExtendedNationalCommodityCode schema and extendedNationalCommodityCodes property supporting up to 16 characters
  • Deprecated existing HSCodes, nationalCommodityCodes, and NationalCommodityCode schema

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 30 comments.

File Description
pint/v3/EBL_PINT_v3.0.0.yaml Adds extended HS code and national commodity code support with deprecation notices for ConsignmentItem and CargoItem schemas
ebl/v3/issuance/EBL_ISS_v3.0.3.yaml Adds extended HS code and national commodity code support with deprecation notices for ConsignmentItem and CargoItem schemas
ebl/v3/EBL_v3.0.3.yaml Adds extended HS code and national commodity code support with deprecation notices across multiple schemas including ConsignmentItem, Commodity, and CargoItem
bkg/v2/BKG_v2.0.4.yaml Adds extended HS code and national commodity code support with deprecation notices for Commodity schema
Comments suppressed due to low confidence (5)

bkg/v2/BKG_v2.0.4.yaml:1

  • Corrected spelling of 'presedence' to 'precedence'.
openapi: 3.0.3

bkg/v2/BKG_v2.0.4.yaml:1

  • Corrected spelling of 'presedence' to 'precedence'.
openapi: 3.0.3

bkg/v2/BKG_v2.0.4.yaml:1

  • Corrected spelling of 'presedence' to 'precedence'.
openapi: 3.0.3

bkg/v2/BKG_v2.0.4.yaml:1

  • The deprecation message incorrectly references extendedHSCodes in the condition. It should reference extendedNationalCommodityCodes to match the pattern used elsewhere in the file.
openapi: 3.0.3

bkg/v2/BKG_v2.0.4.yaml:1

  • Corrected spelling of 'presedence' to 'precedence'.
openapi: 3.0.3

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@HenrikHL HenrikHL requested a review from Copilot January 5, 2026 07:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@HenrikHL HenrikHL requested a review from Copilot January 5, 2026 07:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 12 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HenrikHL and others added 9 commits January 5, 2026 08:41
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@HenrikHL HenrikHL requested a review from Copilot January 5, 2026 07:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

HenrikHL and others added 2 commits January 5, 2026 08:47
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@HenrikHL HenrikHL requested a review from Copilot January 5, 2026 07:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HenrikHL HenrikHL requested a review from Copilot January 5, 2026 07:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 16 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HenrikHL HenrikHL merged commit b1e4788 into master Jan 6, 2026
1 check passed
@HenrikHL HenrikHL deleted the DT-2666_Update-HSCode-and-NationalCommodityCode branch January 6, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants