-
Notifications
You must be signed in to change notification settings - Fork 16
BKG 2.0, EBL 3.0: DT-2666: Update HSCode and NationalCommodityCode #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BKG 2.0, EBL 3.0: DT-2666: Update HSCode and NationalCommodityCode #582
Conversation
PR Compliance Guide 🔍(Compliance updated until commit 0f4b9df)Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label Previous compliance checksCompliance check up to commit 861f15f
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
PR Code Suggestions ✨Latest suggestions up to 0f4b9df
Previous suggestions✅ Suggestions up to commit 861f15f
|
||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR extends support for HS codes from 10 to 12 digits and national commodity codes from an unspecified length to 16 characters, addressing ticket DT-2666. To maintain backward compatibility, new properties (extendedHSCodes and extendedNationalCommodityCodes) and a new schema (ExtendedNationalCommodityCode) are introduced while deprecating the original ones.
Key changes:
- Introduced
extendedHSCodesproperty supporting 6-12 digit codes (vs. original 6-10) - Created
ExtendedNationalCommodityCodeschema andextendedNationalCommodityCodesproperty supporting up to 16 characters - Deprecated existing
HSCodes,nationalCommodityCodes, andNationalCommodityCodeschema
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 30 comments.
| File | Description |
|---|---|
| pint/v3/EBL_PINT_v3.0.0.yaml | Adds extended HS code and national commodity code support with deprecation notices for ConsignmentItem and CargoItem schemas |
| ebl/v3/issuance/EBL_ISS_v3.0.3.yaml | Adds extended HS code and national commodity code support with deprecation notices for ConsignmentItem and CargoItem schemas |
| ebl/v3/EBL_v3.0.3.yaml | Adds extended HS code and national commodity code support with deprecation notices across multiple schemas including ConsignmentItem, Commodity, and CargoItem |
| bkg/v2/BKG_v2.0.4.yaml | Adds extended HS code and national commodity code support with deprecation notices for Commodity schema |
Comments suppressed due to low confidence (5)
bkg/v2/BKG_v2.0.4.yaml:1
- Corrected spelling of 'presedence' to 'precedence'.
openapi: 3.0.3
bkg/v2/BKG_v2.0.4.yaml:1
- Corrected spelling of 'presedence' to 'precedence'.
openapi: 3.0.3
bkg/v2/BKG_v2.0.4.yaml:1
- Corrected spelling of 'presedence' to 'precedence'.
openapi: 3.0.3
bkg/v2/BKG_v2.0.4.yaml:1
- The deprecation message incorrectly references
extendedHSCodesin the condition. It should referenceextendedNationalCommodityCodesto match the pattern used elsewhere in the file.
openapi: 3.0.3
bkg/v2/BKG_v2.0.4.yaml:1
- Corrected spelling of 'presedence' to 'precedence'.
openapi: 3.0.3
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 12 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 16 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DT-2666: Support 12-digit HS codes and 16-digit nationalCommodityCode
Because of backward compatibility issues - a new
NationalCommodityCodeobject calledExtendedNationalCommodityCodeneeded to be created and linked to.Because
HSCodessometimes is a mandatory property - it needs to be provided at the same time asExtendedHSCodes