Check for and exclude thumbnails #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no checking for thumbnails already imported to the wordpress library, so if a thumbnail is detected, it should be ignored from the list. I also added checking for original images from updraft to exclude those from the list as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no checking for thumbnails already imported to the wordpress library, so if a thumbnail is detected, it should be ignored from the list. I also added checking for original images from updraft to exclude those from the list as well.
Ideally, there would be a settings toggle to hide or show thumbnails. Personally, as for the official build of this plugin, I would recommend only implementing the thumbnail option as updraft is a very user-specific option.
As for this PR, I am including both filters so you can use either of them if you would like. I am more than happy to continue the conversation to get this into the official plugin based on your recommendations.
Thanks for this plugin! With my changes, it saved me a ton of time!!!