Skip to content

Conversation

@nickchomey
Copy link
Contributor

@nickchomey nickchomey commented Jan 22, 2026

The Issue

How This PR Solves The Issue

Updates configuration to append xdebug.ini and xhprof.ini config dynamically without hardcoding.

Manual Testing Instructions

ddev add-on get https://github.com/ddev/ddev-frankenphp/tarball/refs/pull/62/head
ddev restart
ddev xdebug on
ddev php -m # no warning here
ddev xhprof on
ddev php -m # no warning here

Automated Testing Overview

Release/Deployment Notes

Copilot AI review requested due to automatic review settings January 22, 2026 23:07
@nickchomey nickchomey changed the title fix xdebug and xhprof ini files - point to proper zts extension .so f… fix xdebug and xhprof ini files - point to proper zts extension .so files Jan 22, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #61 where xdebug and xhprof extensions fail to load in FrankenPHP because the copied ini files reference the wrong shared object file names. The php-zts extensions use versioned naming (e.g., xdebug-zts-84.so) instead of the standard naming (e.g., xdebug.so).

Changes:

  • Adds sed commands to update the ini file references from standard .so names to versioned -zts-XX.so names for xdebug and xhprof extensions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

We also needs a proper validation in tests, to prevent things like this in the future.

I'm going to look closer into this, maybe it's better not to rely entirely on our ini files.

@stasadev stasadev changed the title fix xdebug and xhprof ini files - point to proper zts extension .so files fix(extensions): make xdebug and xhprof work, add better test coverage, fixes #61 Jan 23, 2026
@stasadev stasadev merged commit 6dd72d7 into ddev:main Jan 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: xdebug and other disabled extensions dont work

2 participants