New features for Singleton object #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructor args - Allows a call to ::getInstance() to return a different class to that expected This feature means that unit tests can override functionality that doesn't require testing. For example, to test the \eBot\Match\Match class, we want to override the \eTools\Rcon\CSGO class so that we don't need to entirely mock the RCON connection, and we can instead test the \eTools\Rcon\CSGO class in a different way later. - Allows a call to ::getInstance() to include constructor arguments This feature means that we can create singletons for objects that require constructor arguments to be provided (e.g. \eTools\Rcon\CSGO).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features to
Singletonallowing class overriding and passing constructor argsRequires PR #50 to be merged first.
Allows a call to
::getInstance()to return a different class to that expectedThis feature means that unit tests can override functionality that doesn't require testing. For example, to test the
\eBot\Match\Matchclass, we want to override the\eTools\Rcon\CSGOclass so that we don't need to entirely mock the RCON layer, and we can instead test the\eTools\Rcon\CSGOclass in a different way later.Allows a call to
::getInstance()to include constructor argumentsThis feature means that we can create singletons for objects that require constructor arguments to be provided (e.g.
\eTools\Rcon\CSGO).