kill flaky drains, wait for PS1 + long-timeout bailout, harden shell #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace time-based drains with marker-based reads: - Only treat PS1 as completion (never PS2) - Regex-parse PS1 to extract exit code; centralize cleanup - Micro-poll while waiting; strip ANSI - Add long-timeout bailout for incomplete input: - On overall timeout: send '\n' -> wait -> send ^D -> wait - Make ^D safe via `set -o ignoreeof` - Startup path: run container with `sleep infinity`; attach via exec(TTY) - Remove `drain()`/`clean_terminal_output()`; add `strip_markers_and_extract_exit_code()` - Tests: stronger 200 assert msg; add base64 pipe case; formatting - Misc: doc comments; slight stop behavior tweak (`Stopped` → NotStarted) - Deps: add `const_format` and `lazy_static` - Timeouts now return 504 - Already-stopped sandbox now returns NotStarted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set -o ignoreeofsleep infinity; attach via exec(TTY)drain()/clean_terminal_output(); addstrip_markers_and_extract_exit_code()Stopped→ NotStarted)const_formatandlazy_static