Skip to content

Conversation

@i-meant-to-be
Copy link
Contributor

@i-meant-to-be i-meant-to-be commented Sep 5, 2025

🚩 연관 이슈

closed #17

📝 작업 내용

  • AGP 업데이트
  • 그 외 라이브러리 버전 업데이트

🏞️ 스크린샷 (선택)

없음

🗣️ 리뷰 요구사항 (선택)

없음

Summary by CodeRabbit

  • 신규 기능

    • 없음
  • 버그 수정

    • 없음
  • 문서

    • 없음
  • 리팩터

    • 없음
  • 스타일

    • 없음
  • 테스트

    • 없음
  • 작업(Chores)

    • 빌드·의존성 버전을 전반적으로 최신화하여 안정성 및 호환성 개선(AGP, Kotlin, Core KTX, Lifecycle, Compose BOM, Material 등).
    • Protobuf 도구 및 Kotlin 프로토buf 버전 업데이트(4.32.0).
    • Hilt 컴파일러 명칭 정리(artifact 이름 변경) 및 KSP, Hilt 버전 소폭 상향.
    • 아이콘 라이브러리 항목 및 protobuf-kotlin-lite 등 라이브러리 카탈로그 항목 추가.

@i-meant-to-be i-meant-to-be self-assigned this Sep 5, 2025
@i-meant-to-be i-meant-to-be added the chore 개발 외 작업 label Sep 5, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 5, 2025

Walkthrough

앱 모듈의 protobuf protoc 아티팩트 버전을 4.31.1 → 4.32.0으로 변경하고, Gradle 버전 카탈로그(gradle/libs.versions.toml)의 여러 라이브러리 버전 및 일부 라이브러리 이름/추가 항목을 업데이트함. 기능 코드 변경은 없음.

Changes

Cohort / File(s) Change Summary
Protobuf 컴파일러 버전 상향
app/build.gradle.kts
protobuf.protoc.artifactcom.google.protobuf:protoc:4.31.1com.google.protobuf:protoc:4.32.0으로 업데이트
버전 카탈로그 업데이트
gradle/libs.versions.toml
여러 버전 시그니처 상향: agp 8.12.08.13.0, kotlin 2.2.02.2.10, coreKtx 1.16.01.17.0, lifecycleRuntimeKtx 2.9.22.9.3, composeBom 2025.07.002025.08.01, material 1.5.0-alpha011.5.0-alpha03, ksp 2.2.0-2.0.22.2.10-2.0.2, hilt 2.572.57.1, protobufKotlin 4.31.14.32.0; 새 버전 icon = "1.7.8" 추가; 라이브러리 매핑 추가/수정(androidx-material3-icons-extended, protobuf-kotlin-lite), hilt-android-compiler 이름 → hilt-compiler 변경

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Assessment against linked issues

Objective Addressed Explanation
라이브러리 버전 업데이트 (#17)

Assessment against linked issues: Out-of-scope changes

(해당 없음)

Possibly related PRs

Poem

깡총, 코드밭에 바람 불어와 🐇
숫자들이 쑥쑥 자라네.
프로토도 한 걸음 위로 점프,
카탈로그엔 아이콘도 반짝—✨
빌드 초원에서 깡총깡총 축하 노래.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 22b0cb3 and 5f4177f.

📒 Files selected for processing (1)
  • gradle/libs.versions.toml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • gradle/libs.versions.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build_and_test
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/#17

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
app/build.gradle.kts (1)

96-96: Hilt KSP 전환 시 의존성 교체 필요

위 TOML 코멘트대로 KSP를 사용한다면, 아래 의존성을 교체하세요.

-    ksp(libs.dagger.hilt.android.compiler)
+    ksp(libs.dagger.hilt.compiler)

대안: KAPT 유지 시 pluginskotlin-kapt 추가 + kapt(libs.dagger.hilt.android.compiler) 사용.

🧹 Nitpick comments (2)
gradle/libs.versions.toml (2)

11-12: Compose BOM 사용 중 개별 버전 지정 제거 제안

BOM을 사용하면 material3 및 material-icons-extended는 버전 명시를 피하는 것이 안전합니다. 현재 개별 버전이 BOM 해석을 덮어쓸 수 있어 스큐 위험이 있습니다.

아래처럼 라이브러리 정의의 version.ref만 제거하세요(versions 키는 당장 유지해도 무방):

-androidx-material3 = { group = "androidx.compose.material3", name = "material3", version.ref = "material" }
+androidx-material3 = { group = "androidx.compose.material3", name = "material3" }

-androidx-material3-icons-extended = { group = "androidx.compose.material", name = "material-icons-extended", version.ref = "icon" }
+androidx-material3-icons-extended = { group = "androidx.compose.material", name = "material-icons-extended" }

추가로, 아이콘 별칭명이 material3를 연상시키는 점은 혼동 여지가 있습니다. 필요 시 compose-material-icons-extended 등으로 리네이밍을 검토해주세요.

Also applies to: 41-44


49-51: Retrofit 3.x 전환 영향 점검 및 명명 일관성

버전 키가 retrofit2 = "3.0.0"로 되어 있어 명명과 메이저가 불일치합니다. 실제 좌표/아티팩트가 3.x에 맞는지, API 브레이킹이 없는지 컴파일/테스트로 확인 부탁드립니다. 필요시 키/별칭 리네이밍을 권장합니다.

리네이밍 예:

- retrofit2 = "3.0.0"
+ retrofit = "3.0.0"

-[libraries]
-squareup-retrofit2 = { group = "com.squareup.retrofit2", name = "retrofit", version.ref = "retrofit2" }
-squareup-retrofit2-converter-gson = { group = "com.squareup.retrofit2", name = "converter-gson", version.ref = "retrofit2" }
+[libraries]
+squareup-retrofit = { group = "com.squareup.retrofit2", name = "retrofit", version.ref = "retrofit" }
+squareup-retrofit-converter-gson = { group = "com.squareup.retrofit2", name = "converter-gson", version.ref = "retrofit" }

(프로덕션 코드에서 libs.squareup.retrofit2* 참조도 함께 변경 필요)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c35452d and 22b0cb3.

📒 Files selected for processing (2)
  • app/build.gradle.kts (1 hunks)
  • gradle/libs.versions.toml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-04T05:28:45.127Z
Learnt from: i-meant-to-be
PR: debate-timer/debate-timer-fe-android#15
File: app/build.gradle.kts:61-75
Timestamp: 2025-08-04T05:28:45.127Z
Learning: protoc 버전 4.31.1과 protobuf-kotlin-lite 4.31.1은 Maven Central에서 정상적으로 사용 가능한 최신 버전이다.

Applied to files:

  • app/build.gradle.kts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build_and_test
🔇 Additional comments (3)
gradle/libs.versions.toml (2)

22-22: protoc/런타임 정합성 상향 — LGTM

protobuf-kotlin-lite = 4.32.0으로 상향되어 앱 모듈의 protoc:4.32.0과 버전 정합성이 맞춰졌습니다. 과거 러닝(4.31.1 사용) 대비 자연스러운 마이너 업데이트로 보이며 문제 없어 보입니다.


3-4: Gradle Wrapper 버전 호환성 확인 완료
gradle/wrapper/gradle-wrapper.properties의 distributionUrl이 Gradle 8.13을 가리켜 AGP 8.13.0 + Kotlin 2.2.10의 최소 요구사항을 충족합니다.

app/build.gradle.kts (1)

63-63: protoc 4.32.0 상향 — lite 런타임과 버전 정합성 OK

protobuf-kotlin-lite 4.32.0(catalog)와 일치합니다. CI에서도 generateProto가 정상 동작하는지만 확인해 주세요.

필요 시: ./gradlew :app:generateDebugProto로 로컬 확인.

# New
icon = "1.7.8"
ksp = "2.2.0-2.0.2"
ksp = "2.2.10-2.0.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Hilt + KSP 조합 잠재 이슈: KSP에는 hilt-compiler 사용 필요

hilt-android-compiler는 일반적으로 KAPT용입니다. KSP를 쓰려면 com.google.dagger:hilt-compiler를 써야 합니다. 현 상태 그대로면 빌드 실패 가능성이 높습니다.

다음 변경을 제안합니다.

TOML에 KSP용 컴파일러 별칭 추가:

 [libraries]
 dagger-hilt-android = { group = "com.google.dagger", name = "hilt-android", version.ref = "hilt" }
 dagger-hilt-android-compiler = { group = "com.google.dagger", name = "hilt-android-compiler", version.ref = "hilt" }
 dagger-hilt-android-testing = { group = "com.google.dagger", name = "hilt-android-testing", version.ref = "hilt" }
+dagger-hilt-compiler = { group = "com.google.dagger", name = "hilt-compiler", version.ref = "hilt" }

그리고 앱 모듈에서는 ksp(libs.dagger.hilt.compiler)로 교체(아래 app/build.gradle.kts 코멘트 참고).
대안: KSP 대신 KAPT를 유지하려면 kotlin-kapt 플러그인과 kapt(libs.dagger.hilt.android.compiler)로 회귀.

Also applies to: 46-48

@i-meant-to-be i-meant-to-be merged commit 93a8ecc into develop Sep 5, 2025
2 checks passed
@i-meant-to-be i-meant-to-be deleted the chore/#17 branch September 5, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore 개발 외 작업

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE] 라이브러리 버전 업데이트

2 participants