Skip to content

HTTP package: fix URL building #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixelistik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HTTP package: fix URL building #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions core-packages/http/lib/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,12 @@ function HTTPRequest (method, url, timeout) {
// request line
var head = [];
var url = this.url();
var path = url.pathname + url.search;
var path;
if (url.search) {
path = url.pathname + url.search;
} else {
path = url.pathname;
}
var request_line = "{} {} HTTP/1.1".format(this.method(), path || "/");
head.push(request_line);
// headers to string (kv) form
Expand Down Expand Up @@ -575,4 +580,4 @@ function HTTPResponse (method, encoding, request) {
* However, before we could consider this optimization, we'd need to optimize the ByteString class,
* and in particular make it possible and fast to concatenate / add in string data to an existing
* byte class. Then we could process the data parts we receive on the fly rather than post-hoc.
*/
*/