725: Pass block display of existing blog_posts on homepage via twig#138
Open
adriennedao wants to merge 4 commits intodebugacademy:developfrom
Open
725: Pass block display of existing blog_posts on homepage via twig#138adriennedao wants to merge 4 commits intodebugacademy:developfrom
adriennedao wants to merge 4 commits intodebugacademy:developfrom
Conversation
adriennedao
changed the title
ashabed
reviewed
Apr 18, 2018
| $variables['blog_block'] = $blog_block; | ||
|
|
||
|
|
||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
It's best to include a blank line at the end of .module files
ashabed
reviewed
Apr 18, 2018
|
|
||
| /*** Blog View ***/ | ||
|
|
||
| h3 { |
Contributor
There was a problem hiding this comment.
The h3 should be nested under .view-id-blog_posts so that it does not impact other h3's on the website
ashabed
reviewed
Apr 18, 2018
| } | ||
|
|
||
| .views-row { | ||
| @include make-xs-column(12); |
Contributor
There was a problem hiding this comment.
the text nested under .views-row should be indented another level for clarity
Contributor
Author
|
Thank you for the feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.