Skip to content

Comments

Added a testimonials content type and view#42

Open
amouer wants to merge 1 commit intodebugsociety:masterfrom
amouer:graduates_view
Open

Added a testimonials content type and view#42
amouer wants to merge 1 commit intodebugsociety:masterfrom
amouer:graduates_view

Conversation

@amouer
Copy link
Contributor

@amouer amouer commented Feb 5, 2015

This is for the testimonials page. Created a view and a content type.

@ashabed
Copy link
Contributor

ashabed commented Feb 7, 2015

@amouer This is headed in the right direction. A few things to change (in priority order):

  1. The entity reference field is named 'field_entityref'. That's similar to naming the testimonials field 'field_longtext' - it needs to be more descriptive than that.
    The purpose of the entity reference field is it's an optional field for referencing user accounts. So a better label would be User account, and better machine name 'field_user_ref'.
  2. The entity reference field has its 'Target type' set as 'Node'. We want its target type to be 'User', so that you can select a User in that field.
  3. Feature name is currently 'testimonials'. It's better for our features to have names unique to our site. A label of Testimonials is good - but the 'machine name' (the name generated when you first create the feature, which is used for filenames), should be something like debug_a_testimonials.

The first 2 are required changes, the third is a 'nice to have'. As this task is due Sunday night, please ensure you get the first 2 corrected and updated in the pull request by Sunday night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants