feat: Show not found name when trying to see unexisting or not owned name #3342

alejandralevy · 2026-02-10T10:43:01Z

ENS Infinite Loader Fix

Accessing non-existent ENS names showed infinite spinner instead of error message.

Changes

1. Redux State - Separate Error Field

src/modules/ens/reducer.ts

Added fetchNameError: ENSError | null to ENSState
FETCH_ENS_REQUEST clears both error and fetchNameError
FETCH_ENS_FAILURE sets both error and fetchNameError
Other requests (list, external) only clear general error, preserving
fetchNameError

2. Selectors - New Error Selector

src/modules/ens/selectors.ts

export const getFetchNameError = (state: RootState) => getState(state).fetchNameError
export const getFetchNameErrorMessage = (state: RootState) => {
  const error = getFetchNameError(state)
  return error ? error.message : null
}

3. Container - Use Isolated Error

  src/components/ENSDetailPage/ENSDetailPage.container.tsx
  // BEFORE: getErrorMessage (shared error)
  // AFTER:  getFetchNameErrorMessage (isolated error)
  const error = useSelector(getFetchNameErrorMessage)

4. Shared Empty State Component

src/components/ENSEmptyState/

Created reusable ENSEmptyState component
Used in ENSDetailPage and ENSListPage
Removed duplicated CSS from ENSListPage

5. Tests

src/modules/ens/reducer.spec.ts

Added tests for FETCH_ENS_REQUEST (clears both errors)
Added tests for FETCH_ENS_FAILURE (sets both errors)
Added tests for FETCH_ENS_LIST_REQUEST (only clears general error)

video.mov

Screen.Recording.2026-02-11.at.11.30.47.mov

vercel · 2026-02-10T10:43:12Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
builder	Ready	Preview, Comment	Feb 11, 2026 11:05am

coveralls · 2026-02-10T10:48:21Z

Pull Request Test Coverage Report for Build 21902527070

Details

6 of 22 (27.27%) changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.04%) to 49.174%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/modules/ens/selectors.ts	2	6	33.33%
src/modules/ens/sagas.ts	0	12	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/modules/ens/sagas.ts	1	36.7%

Totals
Change from base Build 21685881015:	0.04%
Covered Lines:	6273
Relevant Lines:	11643

💛 - Coveralls

RocioCM

Works perfect when the name doen't exist, but should we handle the case where the name exists but you are not the owner?

Screen.Recording.2026-02-10.at.10.02.18.AM.mov

nicoecheza · 2026-02-10T13:09:05Z

src/modules/ens/selectors.ts

+export const getFetchNameError = (state: RootState) => getState(state).fetchNameError
+
+export const getFetchNameErrorMessage = (state: RootState) => {
+  const error = getFetchNameError(state)
+  if (error) {
+    return error.message
+  }
+
+  return null
+}


getFetch... sounds weird. maybe we can just change the prop in the slice to something simpler so this getter is easier to name 🚀

renamed to ensError

…ot belong to them

cyaiox · 2026-02-10T17:53:23Z

src/components/ENSDetailPage/ENSDetailPage.tsx

-                ) : null}
-              </span>
+    <LoggedInDetailPage activeTab={NavigationTab.NAMES} isPageFullscreen={true} isLoading={isLoading}>
+      {!isLoading && error ? (


Suggested change

{!isLoading && error ? (

{!isLoading && (error || !ens) ? (

there's a validation 2 lines down to check that there's an ens before showing the info. If I add that validation there, it creates a glitch on the UI because ens is undefined at the beggining

ui.bug.mov

cyaiox · 2026-02-10T17:56:01Z

src/modules/ens/reducer.ts

+        ...state,
+        loading: loadingReducer(state.loading, action),
+        error: { ...action.payload.error },
+        fetchNameError: { ...action.payload.error }


I think you can continue using error for this case

Suggested change

fetchNameError: { ...action.payload.error }

renamed to ensError

cyaiox · 2026-02-10T17:57:16Z

src/modules/ens/selectors.ts

+export const getFetchNameError = (state: RootState) => getState(state).fetchNameError
+
+export const getFetchNameErrorMessage = (state: RootState) => {
+  const error = getFetchNameError(state)
+  if (error) {
+    return error.message
+  }
+
+  return null
+}


related to the reducer comment, I think you can continue using getErrorMessage

Suggested change

export const getFetchNameError = (state: RootState) => getState(state).fetchNameError

export const getFetchNameErrorMessage = (state: RootState) => {

const error = getFetchNameError(state)

if (error) {

return error.message

}

return null

}

renamed to ensError

cyaiox · 2026-02-11T15:29:10Z

src/modules/ens/reducer.ts

+      return {
+        ...state,
+        loading: loadingReducer(state.loading, action),
+        error: { ...action.payload.error },


Suggested change

error: { ...action.payload.error },

cyaiox · 2026-02-11T15:29:30Z

src/modules/ens/reducer.ts

+    case FETCH_ENS_REQUEST: {
+      return {
+        ...state,
+        error: null,


Suggested change

error: null,

feat: show empty state when name does not existe

33aacd7

feat: use separated error state for fetching names or name list

24b7808

vercel bot had a problem deploying to Preview February 10, 2026 12:01 Failure

feat: fix tests

5503f54

vercel bot deployed to Preview February 10, 2026 12:08 View deployment

RocioCM reviewed Feb 10, 2026

View reviewed changes

nicoecheza approved these changes Feb 10, 2026

View reviewed changes

alejandralevy changed the title ~~feat: Show empty state when name does not exist~~ feat: Show not found name when trying to see unexisting or not owned name Feb 10, 2026

feat: show also empty state when user is accessing a name that does n…

244d37d

…ot belong to them

vercel bot deployed to Preview February 10, 2026 17:37 View deployment

cyaiox reviewed Feb 10, 2026

View reviewed changes

feat: add another state when name exists but user is not the owner

d1dac6a

vercel bot deployed to Preview February 10, 2026 18:35 View deployment

feat: rename ens error state and selectors

52c2830

vercel bot deployed to Preview February 11, 2026 10:41 View deployment

feat: remove ens validation to avoid glitch on ui

2446a2b

vercel bot deployed to Preview February 11, 2026 11:05 View deployment

cyaiox reviewed Feb 11, 2026

View reviewed changes

src/modules/ens/reducer.ts

case FETCH_ENS_REQUEST: {

return {

...state,

error: null,

Copy link

Member

cyaiox Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

error: null,

cyaiox approved these changes Feb 11, 2026

View reviewed changes

feat: Show not found name when trying to see unexisting or not owned name #3342

Are you sure you want to change the base?

feat: Show not found name when trying to see unexisting or not owned name #3342

Uh oh!

Conversation

alejandralevy commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ENS Infinite Loader Fix

Changes

1. Redux State - Separate Error Field

2. Selectors - New Error Selector

3. Container - Use Isolated Error

4. Shared Empty State Component

5. Tests

Uh oh!

vercel bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 21902527070

Details

💛 - Coveralls

Uh oh!

RocioCM left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cyaiox Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alejandralevy commented Feb 10, 2026 •

edited

Loading

vercel bot commented Feb 10, 2026 •

edited

Loading

coveralls commented Feb 10, 2026 •

edited

Loading

cyaiox Feb 10, 2026 •

edited

Loading