This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Open
Conversation
|
After the CI passes:
|
4 tasks
pablitar
reviewed
Jul 29, 2021
kernel/packages/shared/dao/index.ts
Outdated
| currentRealm = getRealm(store.getState()) | ||
| if (currentRealm && !deepEqual(previousRealm, currentRealm)) { | ||
| onRealmChange(previousRealm, currentRealm) | ||
| await getJWT(currentRealm) |
Contributor
There was a problem hiding this comment.
Would it make sense to add this as a subscriptor instead of directly adding it in this method?
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code to fetch the cookie with the JWT after implementing Proof of Work every time the realm is changed (this includes start-up).
This PR doesn't include the changes to send the JWT cookie on every request to the Catalyst, as we need to deploy the Catalyst version that handles Cors with origin first.
This PR is blocked to merge until the release of the Catalyst that handles cors with dynamic origin is deployed.